From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 79F87607DE for ; Tue, 17 Nov 2020 18:58:07 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6DC7113A63 for ; Tue, 17 Nov 2020 18:57:37 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 22DB013A56 for ; Tue, 17 Nov 2020 18:57:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D8FA8437E8 for ; Tue, 17 Nov 2020 18:57:35 +0100 (CET) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pbs-devel@lists.proxmox.com Date: Tue, 17 Nov 2020 18:57:18 +0100 Message-Id: <20201117175725.3634238-1-f.gruenbichler@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.023 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [benchmark.rs, mount.rs, key.rs] Subject: [pbs-devel] [PATCH proxmox-backup 0/7] add, persist and check key fingerprint X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Nov 2020 17:58:07 -0000 next improvements/follow-ups in this area: - return fingerprint via SnapshotListItem, display somehow in GUI (pending list_snapshot refactor which is waiting for review) - filter snapshot list by fingerprint and/or crypt mode (for GUI, client, PVE)? - display in PVE (storage key fingerprint in storage config view, manifest fingerprint via new attribute mechanism once its returned by list_snapshot?) - postinst to fixup PVE generated keys via change-passphrase - switch libproxmox-backup-qemu to just call crypt_config.fingerprint() longer term ideas: - some sort of keyring? multiple keys in a single keyfile to allow rotation? Fabian Grünbichler (7): crypt config: add fingerprint mechanism key: add fingerprint to key config client: print key fingerprint and master key client: add 'key show' command fix #3139: add key fingerprint to manifest manifest: check fingerprint when loading with key client: check fingerprint after downloading manifest src/backup/crypt_config.rs | 17 +++++- src/backup/key_derivation.rs | 23 ++++++-- src/backup/manifest.rs | 33 ++++++++++++ src/bin/proxmox-backup-client.rs | 14 +++-- src/bin/proxmox_backup_client/benchmark.rs | 2 +- src/bin/proxmox_backup_client/catalog.rs | 6 ++- src/bin/proxmox_backup_client/key.rs | 63 ++++++++++++++++++++-- src/bin/proxmox_backup_client/mount.rs | 7 ++- src/tools/format.rs | 58 ++++++++++++++++++++ 9 files changed, 208 insertions(+), 15 deletions(-) -- 2.20.1