From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id EA843677E0 for ; Tue, 10 Nov 2020 10:18:39 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B50A31DAC3 for ; Tue, 10 Nov 2020 10:18:09 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 44DB61DAA5 for ; Tue, 10 Nov 2020 10:18:09 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 124AA4605F for ; Tue, 10 Nov 2020 10:18:09 +0100 (CET) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Tue, 10 Nov 2020 10:18:07 +0100 Message-Id: <20201110091808.4476-3-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201110091808.4476-1-d.csapak@proxmox.com> References: <20201110091808.4476-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.383 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 3/4] ui: refactor calculate_dedup_factor X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Nov 2020 09:18:40 -0000 so that we can reuse this Signed-off-by: Dominik Csapak --- www/Utils.js | 8 ++++++++ www/datastore/Summary.js | 5 +---- 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/www/Utils.js b/www/Utils.js index 2d0993a3..f678a916 100644 --- a/www/Utils.js +++ b/www/Utils.js @@ -247,6 +247,14 @@ Ext.define('PBS.Utils', { }; }, + calculate_dedup_factor: function(gcstatus) { + let dedup = 1.0; + if (gcstatus['disk-bytes'] > 0) { + dedup = (gcstatus['index-data-bytes'] || 0)/gcstatus['disk-bytes']; + } + return dedup; + }, + constructor: function() { var me = this; diff --git a/www/datastore/Summary.js b/www/datastore/Summary.js index ac3f19e2..5c757e8c 100644 --- a/www/datastore/Summary.js +++ b/www/datastore/Summary.js @@ -57,10 +57,7 @@ Ext.define('PBS.DataStoreInfo', { let gcstatus = store.getById('gc-status').data.value; - let dedup = 1.0; - if (gcstatus['disk-bytes'] > 0) { - dedup = (gcstatus['index-data-bytes'] || 0)/gcstatus['disk-bytes']; - } + let dedup = PBS.Utils.calculate_dedup_factor(gcstatus); let countstext = function(count) { count = count || {}; -- 2.20.1