From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8735D65DFF for ; Thu, 5 Nov 2020 11:58:16 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 75E2516CFF for ; Thu, 5 Nov 2020 11:57:46 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 027F816CF7 for ; Thu, 5 Nov 2020 11:57:46 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B8B0C46025 for ; Thu, 5 Nov 2020 11:57:45 +0100 (CET) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Thu, 5 Nov 2020 11:57:44 +0100 Message-Id: <20201105105744.30331-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.404 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [data.id] Subject: [pbs-devel] [RFC PATCH] ui: add datastore usage also to 'datastore' navigation element X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Nov 2020 10:58:16 -0000 Signed-off-by: Dominik Csapak --- it is not much, but better than nothing i suppose? i also tried moving the whole dashboard there, but that was very weird and confusing to use.... www/Dashboard.js | 1 + www/NavigationTree.js | 6 ++---- www/dashboard/DataStoreStatistics.js | 2 +- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/www/Dashboard.js b/www/Dashboard.js index 6d5ccc27..55aac493 100644 --- a/www/Dashboard.js +++ b/www/Dashboard.js @@ -311,6 +311,7 @@ Ext.define('PBS.Dashboard', { }, { xtype: 'pbsDatastoresStatistics', + title: gettext('Datastore Usage'), height: 250, }, { diff --git a/www/NavigationTree.js b/www/NavigationTree.js index 09c58938..7eab4c33 100644 --- a/www/NavigationTree.js +++ b/www/NavigationTree.js @@ -84,8 +84,9 @@ Ext.define('PBS.store.NavigationStore', { ], }, { - text: gettext('Datastore'), + text: gettext('Datastores'), iconCls: 'fa fa-archive', + path: 'pbsDatastoresStatistics', id: 'datastores', expanded: true, expandable: false, @@ -174,9 +175,6 @@ Ext.define('PBS.view.main.NavigationTree', { listeners: { itemclick: function(tl, info) { - if (info.node.data.id === 'datastores') { - return false; - } if (info.node.data.id === 'addbutton') { let me = this; Ext.create('PBS.DataStoreEdit', { diff --git a/www/dashboard/DataStoreStatistics.js b/www/dashboard/DataStoreStatistics.js index 3aaa3c9b..478f576f 100644 --- a/www/dashboard/DataStoreStatistics.js +++ b/www/dashboard/DataStoreStatistics.js @@ -40,7 +40,7 @@ Ext.define('PBS.DatastoreStatistics', { extend: 'Ext.grid.Panel', alias: 'widget.pbsDatastoresStatistics', - title: gettext('Datastore Usage'), + title: gettext('Datastores'), emptyText: gettext('No Data'), -- 2.20.1