From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E6CA860863 for ; Thu, 15 Oct 2020 12:49:57 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id E323211FD0 for ; Thu, 15 Oct 2020 12:49:27 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 0834211FAC for ; Thu, 15 Oct 2020 12:49:26 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B6CD745D9C for ; Thu, 15 Oct 2020 12:49:25 +0200 (CEST) From: Stefan Reiter To: pbs-devel@lists.proxmox.com Date: Thu, 15 Oct 2020 12:49:12 +0200 Message-Id: <20201015104916.21170-1-s.reiter@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.037 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [manifest.rs, environment.rs, backup.rs, verify.rs, lib.rs, datastore.rs] Subject: [pbs-devel] [PATCH v2 0/4] Locking and rustdoc improvements X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Oct 2020 10:49:57 -0000 Getting our locking into better shape, now with at least 10% more flocks/mutexes and 14% fewer bugs! * Order now, and you will even receive an updated documentation providing lots of detail on how said locking actually works! * terms and conditions may apply With these patches applied, all interactions displayed in the table in patch 11 resolve fine in theory, in practice I couldn't trigger any of the known races we had previously anymore either. Extra thourough review/testing still appreciated, locking is hard... v2: * Drop applied patches * Use lock file and update_manifest method for manifest * Don't hold manifest lock across verify * Drop Error.context() from path 1, use File::open directly instead * Update docs for v2 changes proxmox-backup: Stefan Reiter (4): gc: avoid race between phase1 and forget/prune datastore: add manifest locking rustdoc: add crate level doc rustdoc: overhaul backup rustdoc and add locking table src/api2/admin/datastore.rs | 8 +- src/api2/backup/environment.rs | 13 +-- src/backup.rs | 199 ++++++++++++++++++++------------- src/backup/datastore.rs | 105 ++++++++++++++--- src/backup/manifest.rs | 1 + src/backup/verify.rs | 9 +- src/lib.rs | 5 + 7 files changed, 229 insertions(+), 111 deletions(-) -- 2.20.1