From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3D6F160329 for ; Wed, 14 Oct 2020 14:17:19 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 393739B0F for ; Wed, 14 Oct 2020 14:16:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 54DF49AB9 for ; Wed, 14 Oct 2020 14:16:47 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 18C4045D6D for ; Wed, 14 Oct 2020 14:16:47 +0200 (CEST) From: Stefan Reiter To: pbs-devel@lists.proxmox.com Date: Wed, 14 Oct 2020 14:16:28 +0200 Message-Id: <20201014121639.25276-1-s.reiter@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.039 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [fs.rs, backup.rs, reader.rs, verify.rs, environment.rs, datastore.rs, lib.rs] Subject: [pbs-devel] [PATCH 00/11] Locking and rustdoc improvements X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Oct 2020 12:17:19 -0000 Getting our locking into better shape, now with at least 10% more flocks/mutexes and 14% fewer bugs! * Order now, and you will even receive an updated documentation providing lots of detail on how said locking actually works! * terms and conditions may apply With these patches applied, all interactions displayed in the table in patch 11 resolve fine in theory, in practice I couldn't trigger any of the known races we had previously anymore either. Extra thourough review/testing still appreciated, locking is hard... proxmox-backup: Stefan Reiter (11): prune: respect snapshot flock prune: never fail, just warn about failed removals backup: use shared flock for base snapshot reader: acquire shared flock on open snapshot verify: acquire shared snapshot flock and skip on error gc: avoid race between phase1 and forget/prune datastore: remove load_manifest_json datastore: add manifest locking datastore: remove individual snapshots before group rustdoc: add crate level doc rustdoc: overhaul backup rustdoc and add locking table src/api2/admin/datastore.rs | 84 +++++++------- src/api2/backup.rs | 4 +- src/api2/backup/environment.rs | 6 +- src/api2/reader.rs | 19 +++- src/backup.rs | 201 ++++++++++++++++++++------------- src/backup/datastore.rs | 132 ++++++++++++++++++---- src/backup/dynamic_index.rs | 5 +- src/backup/fixed_index.rs | 7 +- src/backup/verify.rs | 22 +++- src/lib.rs | 5 + src/tools/fs.rs | 22 +++- 11 files changed, 345 insertions(+), 162 deletions(-) -- 2.20.1