From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E280B601F1 for ; Wed, 14 Oct 2020 13:56:01 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D03819678 for ; Wed, 14 Oct 2020 13:55:31 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 4F03B966E for ; Wed, 14 Oct 2020 13:55:31 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1454045D57 for ; Wed, 14 Oct 2020 13:55:31 +0200 (CEST) Date: Wed, 14 Oct 2020 13:55:30 +0200 From: Wolfgang Bumiller To: Hannes Laimer Cc: pbs-devel@lists.proxmox.com Message-ID: <20201014115530.pwjlgmpjreygutor@olga.proxmox.com> References: <20201013093309.14917-1-h.laimer@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201013093309.14917-1-h.laimer@proxmox.com> User-Agent: NeoMutt/20180716 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox-backup-proxy.rs, mod.rs, verify.rs, config.rs, datastore.rs, admin.rs] Subject: Re: [pbs-devel] [PATCH v3 proxmox-backup 00/14] add job based verify scheduling X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Oct 2020 11:56:01 -0000 Acked code wise mostly, some cleanups afterwards would be nice, but not worth resending the series. On Tue, Oct 13, 2020 at 11:32:55AM +0200, Hannes Laimer wrote: > Replaces the first implementation of scheduled verification with a new > job-based version with additional options that may be specified through > the web ui. > > Options available for verification jobs: > * schedule when to run the job > * set datastore on which the job should run > * set a number of days after which a verification becomes "outdated" > empty => verifications are valid forever > * specify if already successfuly verified snapshots should be verified > again even if they're not outdated(failed ones will always be done) > > > v3: > * restructure do_verification_job function > * renamed 'verify' in config to 'verification' > * add cbind to 'Days valid' field in frontend > > v2: > * added 'Ignire Verified' column in WebUI > * rebased onto master > * log number of planned verification > * ignore_verified is not optional anymore > * adjusted default column width for 'Days valid' > * failed verifications won't be verified again > * use proxmox::try_block! in worker > > > Hannes Laimer (14): > add two new schemas for verification jobs > add verification job config > api2: add verify job config endpoint > add do_verification_job function to verify.rs > api2: add verification job admin endpoint > add scheduling for verification jobs > set a diffrent worker_type based on what is going to be > verified(snapshot, group, ds) > ui: add verification job view > ui: add verification job edit window > ui: add task descriptions for the different types of verification(job, > snapshpt, group, ds) > remove verify_schedule field from datastore config endpoint > remove verify_schedule field from DatastoreConfig > remove verify-schedule field from DataStoreEdit and DataStoreConfig > remove old verification scheduling from proxmox-backup-proxy.rs > > src/api2/admin.rs | 4 +- > src/api2/admin/datastore.rs | 5 +- > src/api2/admin/verify.rs | 107 ++++++++++++ > src/api2/config.rs | 2 + > src/api2/config/datastore.rs | 24 --- > src/api2/config/verify.rs | 274 +++++++++++++++++++++++++++++++ > src/api2/types/mod.rs | 12 +- > src/backup/verify.rs | 94 +++++++++++ > src/bin/proxmox-backup-proxy.rs | 115 ++++--------- > src/config.rs | 1 + > src/config/datastore.rs | 6 - > src/config/verify.rs | 189 +++++++++++++++++++++ > www/Makefile | 2 + > www/NavigationTree.js | 6 + > www/Utils.js | 5 +- > www/config/DataStoreConfig.js | 2 +- > www/config/VerifyView.js | 280 ++++++++++++++++++++++++++++++++ > www/window/DataStoreEdit.js | 9 - > www/window/VerifyJobEdit.js | 93 +++++++++++ > 19 files changed, 1102 insertions(+), 128 deletions(-) > create mode 100644 src/api2/admin/verify.rs > create mode 100644 src/api2/config/verify.rs > create mode 100644 src/config/verify.rs > create mode 100644 www/config/VerifyView.js > create mode 100644 www/window/VerifyJobEdit.js > > -- > 2.20.1