From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B783F612A7 for ; Tue, 13 Oct 2020 10:58:50 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A9F7AC3BF for ; Tue, 13 Oct 2020 10:58:50 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 1B4B3C3B6 for ; Tue, 13 Oct 2020 10:58:50 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DE92245D2F for ; Tue, 13 Oct 2020 10:58:49 +0200 (CEST) From: Dylan Whyte To: pbs-devel@lists.proxmox.com Date: Tue, 13 Oct 2020 10:58:40 +0200 Message-Id: <20201013085841.22773-1-d.whyte@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.024 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [datastore.rs] Subject: [pbs-devel] [PATCH proxmox-backup 1/2] fix #2847: api: datastore: change backup owner X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Oct 2020 08:58:50 -0000 This adds an api method to change the owner of a backup-group. Signed-off-by: Dylan Whyte --- src/api2/admin/datastore.rs | 56 +++++++++++++++++++++++++++++++++++++ 1 file changed, 56 insertions(+) diff --git a/src/api2/admin/datastore.rs b/src/api2/admin/datastore.rs index c260b62d..f4c4e2de 100644 --- a/src/api2/admin/datastore.rs +++ b/src/api2/admin/datastore.rs @@ -1492,6 +1492,57 @@ fn set_notes( Ok(()) } +#[api( + input: { + properties: { + store: { + schema: DATASTORE_SCHEMA, + }, + group: { + description: "Backup group.", + }, + "new-owner": { + description: "Userid of new owner.", + }, + }, + }, + access: { + permission: &Permission::Privilege(&["datastore", "{store}"], PRIV_DATASTORE_MODIFY, true), + }, +)] +/// Change owner of a backup group +fn set_backup_owner( + store: String, + group: String, + new_owner: String, + rpcenv: &mut dyn RpcEnvironment, +) -> Result<(), Error> { + + let datastore = DataStore::lookup_datastore(&store)?; + + // user requesting change of owner + let userid: Userid = rpcenv.get_user().unwrap().parse()?; + let user_info = CachedUserInfo::new()?; + let user_privs = user_info.lookup_privs(&userid, &["datastore", &store]); + + let backup_group: BackupGroup = group.parse()?; + + let new_owner: Userid = new_owner.parse()?; + let new_owner_info = CachedUserInfo::new()?; + + if new_owner_info.is_active_user(&new_owner) { + let allowed = (user_privs & PRIV_DATASTORE_MODIFY) != 0; + if !allowed { check_backup_owner(&datastore, &backup_group, &userid)?; } + + datastore.set_owner(&backup_group, &new_owner, true)?; + + } else { + bail!("user {} is inactive or non-existent", new_owner); + } + + Ok(()) +} + #[sortable] const DATASTORE_INFO_SUBDIRS: SubdirMap = &[ ( @@ -1499,6 +1550,11 @@ const DATASTORE_INFO_SUBDIRS: SubdirMap = &[ &Router::new() .get(&API_METHOD_CATALOG) ), + ( + "change-owner", + &Router::new() + .post(&API_METHOD_SET_BACKUP_OWNER) + ), ( "download", &Router::new() -- 2.20.1