From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id CFAF76082A for ; Thu, 8 Oct 2020 15:37:28 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CD821F92B for ; Thu, 8 Oct 2020 15:37:28 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 8EACEF909 for ; Thu, 8 Oct 2020 15:37:27 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 540D845C48 for ; Thu, 8 Oct 2020 15:37:27 +0200 (CEST) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pbs-devel@lists.proxmox.com Date: Thu, 8 Oct 2020 15:37:19 +0200 Message-Id: <20201008133720.2894310-2-f.gruenbichler@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20201008133720.2894310-1-f.gruenbichler@proxmox.com> References: <20201008133720.2894310-1-f.gruenbichler@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.035 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [userid.rs] Subject: [pbs-devel] [PATCH proxmox-backup 2/3] Userid: fix borrow/deref recursion X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Oct 2020 13:37:28 -0000 not triggered by any current code, but this would lead to a stack exhaustion since borrow would call deref which would call borrow again.. Signed-off-by: Fabian Grünbichler --- src/api2/types/userid.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/api2/types/userid.rs b/src/api2/types/userid.rs index f0a61031..44cd10b7 100644 --- a/src/api2/types/userid.rs +++ b/src/api2/types/userid.rs @@ -131,13 +131,13 @@ impl std::ops::Deref for Username { impl Borrow for Username { fn borrow(&self) -> &UsernameRef { - UsernameRef::new(self.as_str()) + UsernameRef::new(self.0.as_str()) } } impl AsRef for Username { fn as_ref(&self) -> &UsernameRef { - UsernameRef::new(self.as_str()) + self.borrow() } } @@ -204,13 +204,13 @@ impl std::ops::Deref for Realm { impl Borrow for Realm { fn borrow(&self) -> &RealmRef { - RealmRef::new(self.as_str()) + RealmRef::new(self.0.as_str()) } } impl AsRef for Realm { fn as_ref(&self) -> &RealmRef { - RealmRef::new(self.as_str()) + self.borrow() } } -- 2.20.1