From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id B44EE60363 for ; Wed, 7 Oct 2020 11:54:09 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A87902D493 for ; Wed, 7 Oct 2020 11:53:39 +0200 (CEST) Received: from dev.dominic.proxmox.com (212-186-127-178.static.upcbusiness.at [212.186.127.178]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3DBCE2D489 for ; Wed, 7 Oct 2020 11:53:36 +0200 (CEST) Received: by dev.dominic.proxmox.com (Postfix, from userid 0) id 19CC9209E4; Wed, 7 Oct 2020 11:53:36 +0200 (CEST) From: =?UTF-8?q?Dominic=20J=C3=A4ger?= To: pbs-devel@lists.proxmox.com Date: Wed, 7 Oct 2020 11:53:25 +0200 Message-Id: <20201007095325.38338-1-d.jaeger@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 1 AWL -0.521 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods KHOP_HELO_FCRDNS 0.398 Relay HELO differs from its IP's reverse DNS NO_DNS_FOR_FROM 0.379 Envelope sender has no MX or A DNS records SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pbs-devel] [PATCH v2 proxmox-backup] Close #3058: ui: RemoteEdit: Add empty texts X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Oct 2020 09:54:09 -0000 Signed-off-by: Dominic Jäger --- v1->v2: Make clear that the emptyTexts are not defaults www/window/RemoteEdit.js | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/www/window/RemoteEdit.js b/www/window/RemoteEdit.js index 56a248e0..6515dce9 100644 --- a/www/window/RemoteEdit.js +++ b/www/window/RemoteEdit.js @@ -34,7 +34,8 @@ Ext.define('PBS.window.RemoteEdit', { { xtype: 'pmxDisplayEditField', name: 'name', - fieldLabel: gettext('Remote'), + fieldLabel: gettext('Remote ID'), + emptyText: 'E.g., new_remote', renderer: Ext.htmlEncode, allowBlank: false, minLength: 4, @@ -48,7 +49,8 @@ Ext.define('PBS.window.RemoteEdit', { name: 'hostport', submitValue: false, vtype: 'HostPort', - fieldLabel: gettext('Host'), + fieldLabel: gettext('Remote Address'), + emptyText: 'E.g., 192.168.10.10', listeners: { change: function(field, newvalue) { let host = newvalue; @@ -94,7 +96,8 @@ Ext.define('PBS.window.RemoteEdit', { xtype: 'proxmoxtextfield', allowBlank: false, name: 'userid', - fieldLabel: gettext('Userid'), + fieldLabel: gettext('User ID'), + emptyText: 'E.g., admin@pbs', }, { xtype: 'textfield', @@ -116,6 +119,7 @@ Ext.define('PBS.window.RemoteEdit', { deleteEmpty: '{!isCreate}', }, fieldLabel: gettext('Fingerprint'), + emptyText: 'Server certificate SHA-256 fingerprint, required for self-signed certificates', }, { xtype: 'proxmoxtextfield', -- 2.20.1