From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 3E34463119 for ; Fri, 2 Oct 2020 10:32:54 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 331B3825A for ; Fri, 2 Oct 2020 10:32:24 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id C086E8272 for ; Fri, 2 Oct 2020 10:32:23 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 8CE324594C for ; Fri, 2 Oct 2020 10:32:23 +0200 (CEST) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Fri, 2 Oct 2020 10:32:23 +0200 Message-Id: <20201002083223.22419-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.154 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods NO_DNS_FOR_FROM 0.379 Envelope sender has no MX or A DNS records RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record Subject: [pbs-devel] [PATCH proxmox-backup] ui: RemoteEdit: only send delete on update X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Oct 2020 08:32:54 -0000 the create api call does not understand the 'delete' paramter, so send it only on update Signed-off-by: Dominik Csapak --- www/window/RemoteEdit.js | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/www/window/RemoteEdit.js b/www/window/RemoteEdit.js index 2296c89a..56a248e0 100644 --- a/www/window/RemoteEdit.js +++ b/www/window/RemoteEdit.js @@ -82,7 +82,9 @@ Ext.define('PBS.window.RemoteEdit', { { xtype: 'proxmoxtextfield', hidden: true, - deleteEmpty: true, + cbind: { + deleteEmpty: '{!isCreate}', + }, name: 'port', }, ], @@ -110,13 +112,17 @@ Ext.define('PBS.window.RemoteEdit', { { xtype: 'proxmoxtextfield', name: 'fingerprint', - deleteEmpty: true, + cbind: { + deleteEmpty: '{!isCreate}', + }, fieldLabel: gettext('Fingerprint'), }, { xtype: 'proxmoxtextfield', name: 'comment', - deleteEmpty: true, + cbind: { + deleteEmpty: '{!isCreate}', + }, fieldLabel: gettext('Comment'), }, ], -- 2.20.1