From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id AC91162D6E for ; Fri, 18 Sep 2020 15:01:16 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id A2C3116414 for ; Fri, 18 Sep 2020 15:01:16 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 7815B16408 for ; Fri, 18 Sep 2020 15:01:15 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 47CEE45439 for ; Fri, 18 Sep 2020 15:01:15 +0200 (CEST) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pbs-devel@lists.proxmox.com Date: Fri, 18 Sep 2020 15:01:07 +0200 Message-Id: <20200918130107.2744333-2-f.gruenbichler@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200918130107.2744333-1-f.gruenbichler@proxmox.com> References: <20200918130107.2744333-1-f.gruenbichler@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.028 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [permission.rs] Subject: [pbs-devel] [PATCH proxmox] permissions: introduce UserParam permission X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Sep 2020 13:01:16 -0000 to safely differentiate between checking - the current user matches some static string - the current user matches the value in some (path) parameter. Signed-off-by: Fabian Grünbichler --- proxmox/src/api/permission.rs | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/proxmox/src/api/permission.rs b/proxmox/src/api/permission.rs index bbaf52f..a35e581 100644 --- a/proxmox/src/api/permission.rs +++ b/proxmox/src/api/permission.rs @@ -16,6 +16,8 @@ pub enum Permission { Anybody, /// Allow access for the specified user User(&'static str), + /// Allow access if specified param matches logged in user + UserParam(&'static str), /// Allow access for the specified group of users Group(&'static str), /// Use a parameter value as userid to run sub-permission tests. @@ -45,6 +47,9 @@ impl fmt::Debug for Permission { Permission::User(ref userid) => { write!(f, "User({})", userid) } + Permission::UserParam(param_name) => { + write!(f, "UserParam({})", param_name) + } Permission::Group(ref group) => { write!(f, "Group({})", group) } @@ -123,6 +128,13 @@ fn check_api_permission_tail( Some(ref userid) => return userid == expected_userid, } } + Permission::UserParam(param_name) => { + match (userid, param.get(¶m_name.to_string())) { + (None, _) => return false, + (_, None) => return false, + (Some(ref userid), Some(ref expected)) => return userid == expected, + } + } Permission::Group(expected_group) => { match userid { None => return false, -- 2.20.1