From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7703F61CC1; Tue, 15 Sep 2020 11:54:54 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 946DF18AAE; Tue, 15 Sep 2020 11:54:53 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id B2B7618850; Tue, 15 Sep 2020 11:54:48 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6C16B44511; Tue, 15 Sep 2020 11:54:48 +0200 (CEST) From: Hannes Laimer To: pbs-devel@lists.proxmox.com, pve-devel@lists.proxmox.com Date: Tue, 15 Sep 2020 11:54:10 +0200 Message-Id: <20200915095420.990827-1-h.laimer@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [directory.rs] Subject: [pbs-devel] [PATCH v4 proxmox-widget-toolkit 0/10] removal of directories in PBS WebUI X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Sep 2020 09:54:54 -0000 Add functionality to remove directories in the PBS WebUI. In order to do that SafeDestroy had to be moved from pve-manager into proxmox-widget-toolkit and the possibility to show a small note in the dialog had to be added. Furthermore specifics to pve-manager in SafeRemove were replaces with a more general approach, namely: 'type' was replaced with 'purgeable' and 'taskName'. Due to the moving and refactorization the usages of SafeDestroy in pve-manager had to be corrected. In order to avoid the extraction of the directory name from the path in the frontend, the api2 now also returns the name of a directory. proxmox-widget-toolkit needs a version bump, pve-manager and proxmox-backup require that new version. v4: - added patch for eslint fixes - api2: use only unwrap in backend, not unwrap and map_or - safe-destroy: note is now text-overflow: ellipsis and a tooltip with the whole note is added - safe-destroy: note component is now hidden by default - pve-manager: fixed remove-button handler name v3: - smaller patches with each doing a single thing - correct indentation for JS files v2: - SafeRemove -> SafeDestroy (keep original name) - generalized SafeDestroy - fixed eslint related issues - split patch [3/5]v1 into two patches proxmox-widget-toolkit: Hannes Laimer (6): safe-destroy: move SafeDestroy from pve-manager here safe-destroy: eslint --fix safe-destroy: replace type with purgeable and taskName safe-destroy: replace var with let/const safe-destroy: add possibility to show a small note utils: add task description for directory removal src/Makefile | 1 + src/Utils.js | 1 + src/window/SafeDestroy.js | 212 ++++++++++++++++++++++++++++++++++++++ 3 files changed, 214 insertions(+) create mode 100644 src/window/SafeDestroy.js pve-manager: Hannes Laimer (2): safe-destroy: use SafeDestroy from proxmox-widget-toolkit remove SafeDestroy from pve-manager www/manager6/Makefile | 1 - www/manager6/ceph/Pool.js | 5 +- www/manager6/lxc/Config.js | 5 +- www/manager6/qemu/Config.js | 5 +- www/manager6/storage/ContentView.js | 5 +- www/manager6/window/SafeDestroy.js | 194 ---------------------------- 6 files changed, 12 insertions(+), 203 deletions(-) delete mode 100644 www/manager6/window/SafeDestroy.js proxmox-backup: Hannes Laimer (2): api2: add name of mount-point to DatastoreMountInfo ui: add remove-button for directories/mount-units src/api2/node/disks/directory.rs | 4 ++++ www/DirectoryList.js | 25 +++++++++++++++++++++++++ 2 files changed, 29 insertions(+) -- 2.20.1