From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id ACE5660561 for ; Wed, 9 Sep 2020 13:54:41 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 8F1541185B for ; Wed, 9 Sep 2020 13:54:11 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 1386411852 for ; Wed, 9 Sep 2020 13:54:11 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D6AE044AB4 for ; Wed, 9 Sep 2020 13:54:10 +0200 (CEST) From: Dominik Csapak To: pbs-devel@lists.proxmox.com Date: Wed, 9 Sep 2020 13:54:10 +0200 Message-Id: <20200909115410.27881-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.122 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LAZY_DOMAIN_SECURITY 1 Sending domain does not have any anti-forgery methods NO_DNS_FOR_FROM 0.379 Envelope sender has no MX or A DNS records RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_NONE 0.001 SPF: sender does not publish an SPF Record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox-backup-proxy.rs] Subject: [pbs-devel] [PATCH proxmox-backup] fix #2983: improve tcp performance X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Sep 2020 11:54:41 -0000 by leaving the buffer sizes on default, we get much better tcp performance for high latency links throughput is still impacted by latency, but much less so when leaving the sizes at default. the disadvantage is slightly higher memory usage of the server (details below) my local benchmarks (proxmox-backup-client benchmark): pbs client: PVE Host Epyc 7351P (16core/32thread) 64GB Memory pbs server: VM on Host 1 Socket, 4 Cores (Host CPU type) 4GB Memory average of 3 runs, rounded to MB/s | no delay | 1ms | 5ms | 10ms | 25ms | without this patch | 230MB/s | 55MB/s | 13MB/s | 7MB/s | 3MB/s | with this patch | 293MB/s | 293MB/s | 249MB/s | 241MB/s | 104MB/s | memory usage (resident memory) of proxmox-backup-proxy: | peak during benchmarks | after benchmarks | without this patch | 144MB | 100MB | with this patch | 145MB | 130MB | Signed-off-by: Dominik Csapak --- src/bin/proxmox-backup-proxy.rs | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/bin/proxmox-backup-proxy.rs b/src/bin/proxmox-backup-proxy.rs index 75065e6f..5844e632 100644 --- a/src/bin/proxmox-backup-proxy.rs +++ b/src/bin/proxmox-backup-proxy.rs @@ -87,8 +87,6 @@ async fn run() -> Result<(), Error> { let acceptor = Arc::clone(&acceptor); async move { sock.set_nodelay(true).unwrap(); - sock.set_send_buffer_size(1024*1024).unwrap(); - sock.set_recv_buffer_size(1024*1024).unwrap(); Ok(tokio_openssl::accept(&acceptor, sock) .await .ok() // handshake errors aren't be fatal, so return None to filter -- 2.20.1