From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7981461BA0 for ; Mon, 7 Sep 2020 17:30:46 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 4598BD638 for ; Mon, 7 Sep 2020 17:30:46 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 112EBD5FD for ; Mon, 7 Sep 2020 17:30:45 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CF8614467D for ; Mon, 7 Sep 2020 17:30:44 +0200 (CEST) From: Stefan Reiter To: pbs-devel@lists.proxmox.com Date: Mon, 7 Sep 2020 17:30:36 +0200 Message-Id: <20200907153036.9324-6-s.reiter@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200907153036.9324-1-s.reiter@proxmox.com> References: <20200907153036.9324-1-s.reiter@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.055 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH v2 proxmox-backup 5/5] backup: touch all chunks, even if they exist X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Sep 2020 15:30:46 -0000 We need to update the atime of chunk files if they already exist, otherwise a concurrently running GC could sweep them away. This is protected with ChunkStore.mutex, so the fstat/unlink does not race with touching. Signed-off-by: Stefan Reiter --- New in v2. src/backup/chunk_store.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/src/backup/chunk_store.rs b/src/backup/chunk_store.rs index abe1d67f..1d9de70a 100644 --- a/src/backup/chunk_store.rs +++ b/src/backup/chunk_store.rs @@ -414,6 +414,7 @@ impl ChunkStore { if let Ok(metadata) = std::fs::metadata(&chunk_path) { if metadata.is_file() { + self.touch_chunk(digest)?; return Ok((true, metadata.len())); } else { bail!("Got unexpected file type on store '{}' for chunk {}", self.name, digest_str); -- 2.20.1