From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A3EDD67C98; Fri, 28 Aug 2020 10:47:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3100D1EF9C; Fri, 28 Aug 2020 10:47:13 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 6D5DD1ED53; Fri, 28 Aug 2020 10:47:08 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 3AE7344931; Fri, 28 Aug 2020 10:47:08 +0200 (CEST) From: Hannes Laimer To: pve-devel@lists.proxmox.com, pbs-devel@lists.proxmox.com Date: Fri, 28 Aug 2020 10:46:52 +0200 Message-Id: <20200828084658.22057-4-h.laimer@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200828084658.22057-1-h.laimer@proxmox.com> References: <20200828084658.22057-1-h.laimer@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [item.id] Subject: [pbs-devel] [PATCH v3 proxmox-widget-toolbox 3/9] safe-destroy: replace var with let/const X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Aug 2020 08:47:44 -0000 Signed-off-by: Hannes Laimer --- all instances of var are replaced with either let or const src/window/SafeDestroy.js | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/src/window/SafeDestroy.js b/src/window/SafeDestroy.js index 71dce24..a6ad458 100644 --- a/src/window/SafeDestroy.js +++ b/src/window/SafeDestroy.js @@ -26,8 +26,8 @@ Ext.define('Proxmox.window.SafeDestroy', { }, getParams: function() { - var me = this; - var purgeCheckbox = me.lookupReference('purgeCheckbox'); + let me = this; + const purgeCheckbox = me.lookupReference('purgeCheckbox'); if (purgeCheckbox.checked) { me.params.purge = 1; } @@ -44,8 +44,8 @@ Ext.define('Proxmox.window.SafeDestroy', { control: { 'field[name=confirm]': { change: function(f, value) { - var view = this.getView(); - var removeButton = this.lookupReference('removeButton'); + const view = this.getView(); + const removeButton = this.lookupReference('removeButton'); if (value === view.getItem().id.toString()) { removeButton.enable(); } else { @@ -53,7 +53,7 @@ Ext.define('Proxmox.window.SafeDestroy', { } }, specialkey: function(field, event) { - var removeButton = this.lookupReference('removeButton'); + const removeButton = this.lookupReference('removeButton'); if (!removeButton.isDisabled() && event.getKey() == event.ENTER) { removeButton.fireEvent('click', removeButton, event); } @@ -61,7 +61,7 @@ Ext.define('Proxmox.window.SafeDestroy', { }, 'button[reference=removeButton]': { click: function() { - var view = this.getView(); + const view = this.getView(); Proxmox.Utils.API2Request({ url: view.getUrl() + view.getParams(), method: 'DELETE', @@ -71,7 +71,7 @@ Ext.define('Proxmox.window.SafeDestroy', { Ext.Msg.alert('Error', response.htmlStatus); }, success: function(response, options) { - var hasProgressBar = !!(view.showProgress && + const hasProgressBar = !!(view.showProgress && response.result.data); if (hasProgressBar) { @@ -79,8 +79,8 @@ Ext.define('Proxmox.window.SafeDestroy', { // when background action is completed view.hide(); - var upid = response.result.data; - var win = Ext.create('Proxmox.window.TaskProgress', { + const upid = response.result.data; + const win = Ext.create('Proxmox.window.TaskProgress', { upid: upid, listeners: { destroy: function() { @@ -150,18 +150,18 @@ Ext.define('Proxmox.window.SafeDestroy', { ], initComponent: function() { - var me = this; + let me = this; me.callParent(); - var item = me.getItem(); + const item = me.getItem(); if (!Ext.isDefined(item.id)) { throw "no ID specified"; } - var messageCmp = me.lookupReference('messageCmp'); - var msg; + const messageCmp = me.lookupReference('messageCmp'); + let msg; if (Ext.isDefined(me.getTaskName())) { msg = Proxmox.Utils.format_task_description(me.getTaskName(), item.id); @@ -171,12 +171,12 @@ Ext.define('Proxmox.window.SafeDestroy', { } if (!item.purgeable) { - let purgeCheckbox = me.lookupReference('purgeCheckbox'); + const purgeCheckbox = me.lookupReference('purgeCheckbox'); purgeCheckbox.setDisabled(true); purgeCheckbox.setHidden(true); } - var confirmField = me.lookupReference('confirmField'); + const confirmField = me.lookupReference('confirmField'); msg = gettext('Please enter the ID to confirm') + ' (' + item.id + ')'; confirmField.setFieldLabel(msg); -- 2.20.1