From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <o.bektas@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id A737F693DC
 for <pbs-devel@lists.proxmox.com>; Wed,  5 Aug 2020 12:15:54 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 9BF9F13965
 for <pbs-devel@lists.proxmox.com>; Wed,  5 Aug 2020 12:15:24 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [212.186.127.180])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id BC1F41395B
 for <pbs-devel@lists.proxmox.com>; Wed,  5 Aug 2020 12:15:23 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 88D14434B4
 for <pbs-devel@lists.proxmox.com>; Wed,  5 Aug 2020 12:15:23 +0200 (CEST)
Date: Wed, 5 Aug 2020 12:15:21 +0200
From: Oguz Bektas <o.bektas@proxmox.com>
To: Fabian =?iso-8859-1?Q?Gr=FCnbichler?= <f.gruenbichler@proxmox.com>
Cc: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>
Message-ID: <20200805101521.GA11449@gaia.proxmox.com>
References: <20200804140136.1203818-1-o.bektas@proxmox.com>
 <129568827.330.1596603028183@webmail.proxmox.com>
 <1596622203.98gp6kwkr5.astroid@nora.none>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1596622203.98gp6kwkr5.astroid@nora.none>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.567 Adjusted score from AWL reputation of From: address
 KAM_ASCII_DIVIDERS        0.8 Spam that uses ascii formatting tricks
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See
 http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more
 information. [datastore.rs, proxmox.com]
Subject: Re: [pbs-devel] [PATCH backup] fix #2909: handle missing chunks
 gracefully in garbage collection
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Wed, 05 Aug 2020 10:15:54 -0000

On Wed, Aug 05, 2020 at 12:11:37PM +0200, Fabian Grünbichler wrote:
> On August 5, 2020 6:50 am, Dietmar Maurer wrote:
> > But now the task finish with status Ok?
> > 
> > IMHO, this is a serious problem...
> >
> 
> for verify this should cause the task to fail, but for GC I am not so 
> sure. the garbage collection itself is fine (by definition, any missing 
> chunk the GC encounters is one that should not be garbage collected), it 
> just found an unrelated problem?

i was thinking the same.

but i'm sending a new version soon

using worker.warn instead of worker.log should make it continue with a
warning status.

> 
> >> On 08/04/2020 4:01 PM Oguz Bektas <o.bektas@proxmox.com> wrote:
> >> 
> >>  
> >> instead of bailing and stopping the entire GC process, log the missing
> >> chunk errors and continue.
> >> 
> >> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> >> ---
> >>  src/backup/datastore.rs | 4 ++--
> >>  1 file changed, 2 insertions(+), 2 deletions(-)
> >> 
> >> diff --git a/src/backup/datastore.rs b/src/backup/datastore.rs
> >> index ffd64b81..063fba53 100644
> >> --- a/src/backup/datastore.rs
> >> +++ b/src/backup/datastore.rs
> >> @@ -436,8 +436,8 @@ impl DataStore {
> >>              tools::fail_on_shutdown()?;
> >>              let digest = index.index_digest(pos).unwrap();
> >>              if let Err(err) = self.chunk_store.touch_chunk(digest) {
> >> -                bail!("unable to access chunk {}, required by {:?} - {}",
> >> -                      proxmox::tools::digest_to_hex(digest), file_name, err);
> >> +                worker.log(&format!("warning: unable to access chunk {}, required by {:?} - {}",
> >> +                      proxmox::tools::digest_to_hex(digest), file_name, err));
> >>              }
> >>          }
> >>          Ok(())
> >> -- 
> >> 2.20.1
> >> 
> >> 
> >> _______________________________________________
> >> pbs-devel mailing list
> >> pbs-devel@lists.proxmox.com
> >> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> > 
> > 
> > _______________________________________________
> > pbs-devel mailing list
> > pbs-devel@lists.proxmox.com
> > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel
> > 
> > 
> >