From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id C2E366913C for ; Tue, 4 Aug 2020 12:42:56 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B8BF7BDBF for ; Tue, 4 Aug 2020 12:42:26 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 146CBBD89 for ; Tue, 4 Aug 2020 12:42:24 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id BF5B44348A for ; Tue, 4 Aug 2020 12:42:23 +0200 (CEST) From: Stefan Reiter To: pbs-devel@lists.proxmox.com Date: Tue, 4 Aug 2020 12:41:58 +0200 Message-Id: <20200804104205.29540-1-s.reiter@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.060 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [proxmox.com, backup.rs, datastore.rs, proxmox-backup-proxy.rs, environment.rs, prune.rs, pull.rs] Subject: [pbs-devel] [PATCH 0/7] More flocking and race elimination X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Aug 2020 10:42:56 -0000 The previous series[0] already fixed some bugs, but it also introduced some new ones, e.g. incomplete but not running backups were unable to be removed. This is the next step to race-free™ backups, this time going all-in on flocks. Patches 1 and 2 are technically unrelated (though necessary), so could be committed standalone. The last patch introduces locking for base backups, but also re-writes the previous (unnecessarily complex) base-snapshot existance check, which is therefor reverted in patch 6. [0] https://lists.proxmox.com/pipermail/pbs-devel/2020-July/000233.html proxmox-backup: Stefan Reiter (7): finish_backup: mark backup as finished only after checks have passed backup: only allow finished backups as base snapshot datastore: prevent in-use deletion with locks instead of heuristic prune: also check backup snapshot locks backup: flock snapshot on backup start Revert "backup: ensure base snapshots are still available after backup" backup: lock base snapshot and ensure existance on finish src/api2/admin/datastore.rs | 2 +- src/api2/backup.rs | 16 +++++--- src/api2/backup/environment.rs | 21 +++-------- src/backup/backup_info.rs | 65 +++++++++++++++++++++++++++++---- src/backup/datastore.rs | 62 +++++++++++-------------------- src/backup/prune.rs | 48 +++++++++++++++++------- src/bin/proxmox-backup-proxy.rs | 2 +- src/client/pull.rs | 2 +- tests/prune.rs | 6 ++- 9 files changed, 136 insertions(+), 88 deletions(-) -- 2.20.1