From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 106AC68F71 for ; Mon, 3 Aug 2020 14:11:37 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0CFD62DBAE for ; Mon, 3 Aug 2020 14:11:07 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 15DCC2DBA4 for ; Mon, 3 Aug 2020 14:11:06 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D83D94302F for ; Mon, 3 Aug 2020 14:11:05 +0200 (CEST) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pbs-devel@lists.proxmox.com Date: Mon, 3 Aug 2020 14:10:46 +0200 Message-Id: <20200803121046.3623216-5-f.gruenbichler@proxmox.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200803121046.3623216-1-f.gruenbichler@proxmox.com> References: <20200803121046.3623216-1-f.gruenbichler@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.042 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 4/4] datastore: allow browsing signed pxar files X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Aug 2020 12:11:37 -0000 just because we can't verify the signature, does not mean the contents are not accessible. it might make sense to make it obvious with a hint or click-through warning that no signature verification can take place or this and downloading. Signed-off-by: Fabian Grünbichler --- www/DataStoreContent.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/www/DataStoreContent.js b/www/DataStoreContent.js index e8690486..62e57817 100644 --- a/www/DataStoreContent.js +++ b/www/DataStoreContent.js @@ -505,7 +505,7 @@ Ext.define('PBS.DataStoreContent', { return !(data.leaf && data.filename && data.filename.endsWith('pxar.didx') && - data['crypt-mode'] < 2); + data['crypt-mode'] < 3); } }, ] -- 2.20.1