From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id E036066CA8 for ; Tue, 28 Jul 2020 14:32:18 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id CC25524F44 for ; Tue, 28 Jul 2020 14:32:18 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 290D124F34 for ; Tue, 28 Jul 2020 14:32:18 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id E1A66433C7 for ; Tue, 28 Jul 2020 14:32:17 +0200 (CEST) From: Stefan Reiter To: pbs-devel@lists.proxmox.com Date: Tue, 28 Jul 2020 14:32:10 +0200 Message-Id: <20200728123211.9276-1-s.reiter@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.047 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 1/2] ui: fix error when reloading DataStoreContent X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Jul 2020 12:32:19 -0000 ...when an entry is selected, that doesn't exist after the reload. E.g. when one deletes selects a file within a snapshot and then clicks the delete icon for said snapshot, focusRow would then fail and the loading mask stay on until a reload. Signed-off-by: Stefan Reiter --- www/DataStoreContent.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/www/DataStoreContent.js b/www/DataStoreContent.js index 5f407e98..1c08f56a 100644 --- a/www/DataStoreContent.js +++ b/www/DataStoreContent.js @@ -232,8 +232,10 @@ Ext.define('PBS.DataStoreContent', { } return selected === id; }, undefined, true); - view.setSelection(selection); - view.getView().focusRow(selection); + if (selection) { + view.setSelection(selection); + view.getView().focusRow(selection); + } } Proxmox.Utils.setErrorMask(view, false); -- 2.20.1