From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <s.ivanov@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 7014265829 for <pbs-devel@lists.proxmox.com>; Thu, 23 Jul 2020 18:16:53 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 595402AB2F for <pbs-devel@lists.proxmox.com>; Thu, 23 Jul 2020 18:16:53 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 368F52AB14 for <pbs-devel@lists.proxmox.com>; Thu, 23 Jul 2020 18:16:49 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0257843344 for <pbs-devel@lists.proxmox.com>; Thu, 23 Jul 2020 18:16:49 +0200 (CEST) From: Stoiko Ivanov <s.ivanov@proxmox.com> To: pbs-devel@lists.proxmox.com Date: Thu, 23 Jul 2020 16:16:35 +0000 Message-Id: <20200723161637.6280-1-s.ivanov@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup 0/2] fix 2885 and a division by zero X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Thu, 23 Jul 2020 16:16:53 -0000 This patchset fixes #2885 (clobbering of the didx file if the same target is used multiple times). The second patch fixes a division by zero panic in case the backup was too fast :) (as_secs() returns 0). Tested on my machine (where I ran into the division by zero issue) Stoiko Ivanov (2): fix 2885: bail on duplicate backup target fix division by zero src/bin/proxmox-backup-client.rs | 6 ++++++ src/client/backup_writer.rs | 11 ++++++++--- 2 files changed, 14 insertions(+), 3 deletions(-) -- 2.20.1