From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <s.reiter@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 43F3C6175E for <pbs-devel@lists.proxmox.com>; Thu, 9 Jul 2020 14:12:56 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 40D231218E for <pbs-devel@lists.proxmox.com>; Thu, 9 Jul 2020 14:12:56 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 1F99D12185 for <pbs-devel@lists.proxmox.com>; Thu, 9 Jul 2020 14:12:55 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DD3D744141 for <pbs-devel@lists.proxmox.com>; Thu, 9 Jul 2020 14:12:54 +0200 (CEST) From: Stefan Reiter <s.reiter@proxmox.com> To: pbs-devel@lists.proxmox.com Date: Thu, 9 Jul 2020 14:12:42 +0200 Message-Id: <20200709121242.26143-1-s.reiter@proxmox.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pbs-devel] [PATCH proxmox-backup-qemu] ignore missing or bad previous index X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Thu, 09 Jul 2020 12:12:56 -0000 This is not a fatal condition, it just means that we cannot do incremental backups client-side. This can happen if a new disk was added the a VM since the last backup for example. Signed-off-by: Stefan Reiter <s.reiter@proxmox.com> --- src/commands.rs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/commands.rs b/src/commands.rs index 9c21702..6f26324 100644 --- a/src/commands.rs +++ b/src/commands.rs @@ -114,7 +114,11 @@ pub(crate) async fn register_image( let index = match manifest { Some(manifest) => { - Some(client.download_previous_fixed_index(&archive_name, &manifest, known_chunks.clone()).await?) + match client.download_previous_fixed_index(&archive_name, &manifest, known_chunks.clone()).await { + Ok(index) => Some(index), + // not having a previous index is not fatal, so ignore errors + Err(_) => None + } }, None => None }; -- 2.20.1