From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <o.bektas@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 2F8D161639
 for <pbs-devel@lists.proxmox.com>; Thu,  9 Jul 2020 10:38:26 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 259241083F
 for <pbs-devel@lists.proxmox.com>; Thu,  9 Jul 2020 10:37:56 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [212.186.127.180])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 9F72E10835
 for <pbs-devel@lists.proxmox.com>; Thu,  9 Jul 2020 10:37:55 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 6AB4A43103
 for <pbs-devel@lists.proxmox.com>; Thu,  9 Jul 2020 10:37:55 +0200 (CEST)
Date: Thu, 9 Jul 2020 10:37:53 +0200
From: Oguz Bektas <o.bektas@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>
Cc: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>
Message-ID: <20200709083753.GA12554@gaia.proxmox.com>
References: <20200708124148.359379-1-o.bektas@proxmox.com>
 <04799f43-b833-2114-0769-a3da133819f7@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <04799f43-b833-2114-0769-a3da133819f7@proxmox.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
X-SPAM-LEVEL: Spam detection results:  0
 AWL 1.585 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] applied: Re: [PATCH proxmox-backup] add
 local-zfs.rst
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Thu, 09 Jul 2020 08:38:26 -0000

On Wed, Jul 08, 2020 at 06:21:16PM +0200, Thomas Lamprecht wrote:
> On 08.07.20 14:41, Oguz Bektas wrote:
> > content is > 90% same as local-zfs.adoc in pve-docs.
> > 
> > adapted the format for .rst
> > 
> > fixed some typos and wrote some parts slightly different (wording).
> > 
> > Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> > ---
> >  docs/local-zfs.rst | 374 +++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 374 insertions(+)
> >  create mode 100644 docs/local-zfs.rst
> > 
> >
> 
> applied, but there's quite a few things to fix. What reStructured text really likes
> are a empty line between a special directive and its content. For example, code-block:
> 
> >.. code-block:: console
> >
> >  options zfs zfs_arc_max=8589934592
> 
> You missed that empty line everywhere. Simple tables have also some rules to follow.

oh. sorry about that, will keep in mind for nex time

> 
> I Included this in sysadmin.rst and move that out as it's own chapter.
thanks!