From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id CB76F61AB9
 for <pbs-devel@lists.proxmox.com>; Tue, 15 Sep 2020 09:42:18 +0200 (CEST)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id BE91617394
 for <pbs-devel@lists.proxmox.com>; Tue, 15 Sep 2020 09:42:18 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [212.186.127.180])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id 45FF017386
 for <pbs-devel@lists.proxmox.com>; Tue, 15 Sep 2020 09:42:18 +0200 (CEST)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 1134344C20
 for <pbs-devel@lists.proxmox.com>; Tue, 15 Sep 2020 09:42:18 +0200 (CEST)
To: Proxmox Backup Server development discussion
 <pbs-devel@lists.proxmox.com>, Dietmar Maurer <dietmar@proxmox.com>,
 Stefan Reiter <s.reiter@proxmox.com>
References: <20200914085019.14101-1-s.reiter@proxmox.com>
 <20200914085019.14101-2-s.reiter@proxmox.com>
 <538882794.11.1600150144899@webmail.proxmox.com>
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
Message-ID: <1f058e9a-a54b-6aef-47f4-6ccb2f4bab68@proxmox.com>
Date: Tue, 15 Sep 2020 09:42:15 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:81.0) Gecko/20100101
 Thunderbird/81.0
MIME-Version: 1.0
In-Reply-To: <538882794.11.1600150144899@webmail.proxmox.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL -0.209 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -0.001 Looks like a legit reply (A)
 RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH v4 proxmox-backup 2/2] backup: check all
 referenced chunks actually exist
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 15 Sep 2020 07:42:18 -0000

On 9/15/20 8:09 AM, Dietmar Maurer wrote:
> unrelated question below:
> 
>  /// Ensure all chunks referenced in this backup actually exist.
>> +    /// Only call *after* all writers have been closed, to avoid race with GC.
>> +    /// In case of error, mark the previous backup as 'verify failed'.
>> +    fn verify_chunk_existance(&self, known_chunks: &KnownChunksMap) -> Result<(), Error> {
>> +        for (digest, (_, checked)) in known_chunks.iter() {
>> +            if !checked && !self.datastore.chunk_path(digest).0.exists() {
>> +                let mark_msg = if let Some(ref last_backup) = self.last_backup {
>> +                    let last_dir = &last_backup.backup_dir;
>> +                    let verify_state = SnapshotVerifyState {
>> +                        state: "failed".to_owned(),
> 
> Why is state a String? This should be an enum instead? Please can you take a look at that? 

It really should be an enum, no idea why I did not made it one to begin with.