From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 18FF61FF17C for ; Wed, 23 Jul 2025 08:32:44 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 9F8428D05; Wed, 23 Jul 2025 08:34:02 +0200 (CEST) Message-ID: <1d6e2724-58a0-4a39-9aa1-28dd0da34c16@proxmox.com> Date: Wed, 23 Jul 2025 08:33:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Thomas Lamprecht , Proxmox Backup Server development discussion References: <20250722124837.864242-1-c.ebner@proxmox.com> <11b67b45-5ac1-4f63-8277-7b0433e356e8@proxmox.com> Content-Language: en-US, de-DE From: Christian Ebner In-Reply-To: <11b67b45-5ac1-4f63-8277-7b0433e356e8@proxmox.com> X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1753252427387 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.044 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] applied: [PATCH proxmox-backup 0/6] fix various s3 related ui/cli/doc issues X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" On 7/22/25 10:25 PM, Thomas Lamprecht wrote: > Am 22.07.25 um 14:49 schrieb Christian Ebner: >> This patch series is a followup to the s3 object store backend for >> Proxmox Backup Server patch series found at: >> https://lore.proxmox.com/pbs-devel/20250722101106.526438-1-c.ebner@proxmox.com/T/ >> >> Most prominently, it moves the S3 endpoint configuration to the remotes, >> splitting the remotes into tabs for the s3 configuration and the remote >> Proxmox Backup Server configuration. >> >> The other patches mostly touch naming, preferring `endpoint` over >> `client` for s3 endpoint configurations. >> >> Also, fixes a small ui issue found by Lukas during testing (thanks for >> the report, still plan to refactor the whole datastore edit window as >> promised once I find the time). >> >> The last patch improves ui by allowing the user to pass the https scheme >> prefix to the endpoint in the ui, stripping it for the backend config. >> >> Christian Ebner (6): >> ui: add tabs for remotes and move s3 endpoint config to it >> ui: use S3 endpoint over S3 client for ui elements >> cli: use `endpoint` over `client` for s3 endpoint subcommands >> docs: use `endpoint` over `client` for the s3 endpoint configuration >> ui: default for s3 overwrite-in-use to be disabled >> ui: s3 client edit: allow for https scheme prefix in endpoint input >> >> docs/storage.rst | 29 ++++++++------- >> src/bin/proxmox_backup_manager/s3.rs | 14 +++---- >> www/Makefile | 1 + >> www/NavigationTree.js | 8 +--- >> www/config/RemoteView.js | 2 +- >> www/config/RemotesOverview.js | 55 ++++++++++++++++++++++++++++ >> www/config/S3ClientView.js | 2 +- >> www/form/S3ClientSelector.js | 2 +- >> www/window/DataStoreEdit.js | 6 ++- >> www/window/S3ClientEdit.js | 6 ++- >> 10 files changed, 92 insertions(+), 33 deletions(-) >> create mode 100644 www/config/RemotesOverview.js >> > > > applied, thanks! I see the first patch (tabs for remotes) was not applied, the Remotes and S3 Endpoints still separate in the side menu. Was this intentional? _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel