From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id DA33B1FF13B for ; Wed, 08 Apr 2026 09:29:17 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 686131C84; Wed, 8 Apr 2026 09:29:53 +0200 (CEST) Message-ID: <1d62a310-86c5-4586-ad38-b1092bf3cd61@proxmox.com> Date: Wed, 8 Apr 2026 09:29:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox{,-backup} 00/20] fix #7251: implement server side encryption support for push sync jobs To: Christian Ebner , pbs-devel@lists.proxmox.com References: <20260401075521.176354-1-c.ebner@proxmox.com> Content-Language: en-US From: David Riley In-Reply-To: <20260401075521.176354-1-c.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775633288484 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.633 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: RP3UT6SAOM425CCLP4BUTOA56SQSH4T6 X-Message-ID-Hash: RP3UT6SAOM425CCLP4BUTOA56SQSH4T6 X-MailFrom: d.riley@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thanks for your work on this. I tested your patches for the proxmox and proxmox-backup repositories and encountered three issues: 1. Push/Pull Job: Form validation error When the encryption key selection is left untouched or disabled, the form fails validation. Reproduction Steps:   Use two PBS instances (PBS1 with patches, PBS2 without).   Create a datastore and an encryption key on PBS1.   Create a datastore on PBS2.   On PBS1, configure a Push Job for the datastore.   Leave the Encryption Key field disabled/untouched and submit the   form. The following error appears: parameter verification errors (400) encryption-key: value must be at least 3 characters long 2. Deleting Encryption Key: "Unknown error" pop-up Deleting an encryption key appears to succeed (the key is removed), but the UI shows an error pop up. Error message: "Unknown error" Observations: No errors are logged in the browser console or the   network tab. 3. Drag and Drop of Encryption Key File Dragging a file from the file explorer into the "Upload from File" form field results in a parsing error. Reproduction Steps:   Create Encryption Key and download it.   Add new key   Drag and drop the just downloaded key file into the form field. The field displays "[object ProgressEvent]" instead of the file content/name. Hovering over it shows: "Failed to parse key - SyntaxError: JSON parse unexpected character at line 1 column 2 of the JSON data" Aside from these three points, the rest of the functionality works as expected.