From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id ED9BEB3A18 for ; Wed, 29 Nov 2023 13:44:40 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D0BD66C2B for ; Wed, 29 Nov 2023 13:44:10 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 29 Nov 2023 13:44:10 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D7E4140A69 for ; Wed, 29 Nov 2023 13:44:09 +0100 (CET) Message-ID: <1d1e79c4-89b0-4b3a-b77b-b5135157083b@proxmox.com> Date: Wed, 29 Nov 2023 13:44:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Wolfgang Bumiller Cc: pbs-devel@lists.proxmox.com References: <20231129090746.38798-1-g.goller@proxmox.com> <20231129090746.38798-3-g.goller@proxmox.com> From: Gabriel Goller In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.187 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [PATCH v4 proxmox-backup 2/5] node: status: added bootmode X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Nov 2023 12:44:41 -0000 On 11/29/23 11:18, Wolfgang Bumiller wrote: > On Wed, Nov 29, 2023 at 10:07:43AM +0100, Gabriel Goller wrote: >> Added field that shows the bootmode of the node. The bootmode is either >> Legacy Bios, EFI, or EFI (Secure Boot). To detect the mode we use the >> exact same method as in pve: We check if the `/sys/firmware/efi` folder >> exists, then check if the `SecureBoot-xx...` file in the `efivars` >> directory has the SecureBoot flag enabled. >> >> Signed-off-by: Gabriel Goller >> --- >> pbs-api-types/src/node.rs | 30 +++++++++++++++++++++++++++--- >> src/api2/node/status.rs | 29 +++++++++++++++++++++++++++-- >> 2 files changed, 54 insertions(+), 5 deletions(-) >> >> diff --git a/pbs-api-types/src/node.rs b/pbs-api-types/src/node.rs >> index 704215bb..ab626157 100644 >> --- a/pbs-api-types/src/node.rs >> +++ b/pbs-api-types/src/node.rs >> @@ -1,9 +1,8 @@ >> -use serde::{Deserialize, Serialize}; >> use proxmox_schema::*; >> +use serde::{Deserialize, Serialize}; >> >> use crate::StorageStatus; >> >> - >> #[api] >> #[derive(Serialize, Deserialize, Default)] >> #[serde(rename_all = "kebab-case")] >> @@ -39,6 +38,29 @@ pub struct NodeInformation { >> pub fingerprint: String, >> } >> >> + >> +#[api] >> +#[derive(Serialize, Deserialize, Copy, Clone)] >> +#[serde(rename_all = "kebab-case")] >> +/// The possible BootModes >> +pub enum BootMode { >> + /// The BootMode is EFI/UEFI >> + Efi, >> + /// The BootMode is Legacy BIOS >> + LegacyBios, >> +} > ^ Should be able to have a From here. I don't know if we want to pull in `proxmox_sys` into `pbs-api-types`?