From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <f.weber@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id A596392C6D for <pbs-devel@lists.proxmox.com>; Wed, 15 Feb 2023 09:11:11 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 7EDCE199F9 for <pbs-devel@lists.proxmox.com>; Wed, 15 Feb 2023 09:10:41 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pbs-devel@lists.proxmox.com>; Wed, 15 Feb 2023 09:10:40 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 0645C47232 for <pbs-devel@lists.proxmox.com>; Wed, 15 Feb 2023 09:10:40 +0100 (CET) Message-ID: <1c87956c-06aa-61bc-8dc6-806b95b421ed@proxmox.com> Date: Wed, 15 Feb 2023 09:10:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 To: Lukas Wagner <l.wagner@proxmox.com> References: <20230214132652.749737-1-l.wagner@proxmox.com> <20230214132652.749737-6-l.wagner@proxmox.com> Content-Language: en-US Cc: pbs-devel@lists.proxmox.com From: Friedrich Weber <f.weber@proxmox.com> In-Reply-To: <20230214132652.749737-6-l.wagner@proxmox.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.560 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment NICE_REPLY_A -0.35 Looks like a legit reply (A) SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH v4 proxmox-widget-toolkit 5/5] auth ui: fix `value not defined in enumeration` error X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion <pbs-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/> List-Post: <mailto:pbs-devel@lists.proxmox.com> List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 15 Feb 2023 08:11:11 -0000 Can confirm that the error is gone now, and the realm settings are saved as expected. Consider this Tested-by: Friedrich Weber <f.weber@proxmox.com> On 14/02/2023 14:26, Lukas Wagner wrote: > ...when editing LDAP realm sync settings and only a single property is > empty and thus to be deleted (e.g. values.delete = "filter"). > > If `delete` is a simple string and not an array, > `Proxmox.Utils.delete_if_default` simply creates a comma-separated list, > (e.g. value.delete = "filter,sync-attributes"). > > When the properties from the other panel are evaluated and added to the > the `delete` property, comma-separated list format is not considered, > leading to a final value for `delete` that could look like this: > value.delete = { > "server2", > "comment", > "filter,sync-attributes" > } > > This commit fixes this by splitting `delete` in case it is a string. > > Reported-by: Friedrich Weber <f.weber@proxmox.com> > Signed-off-by: Lukas Wagner <l.wagner@proxmox.com> > --- > src/window/AuthEditLDAP.js | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/src/window/AuthEditLDAP.js b/src/window/AuthEditLDAP.js > index aa85c5d..3e8ce88 100644 > --- a/src/window/AuthEditLDAP.js > +++ b/src/window/AuthEditLDAP.js > @@ -243,6 +243,11 @@ Ext.define('Proxmox.panel.LDAPSyncInputPanel', { > Proxmox.Utils.delete_if_default(values, 'sync-defaults-options'); > Proxmox.Utils.delete_if_default(values, 'sync-attributes'); > > + // Force values.delete to be an array > + if (typeof values.delete === 'string') { > + values.delete = values.delete.split(','); > + } > + > if (me.isCreate) { > delete values.delete; // on create we cannot delete values > }