From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 8A4E620EC91 for ; Tue, 30 Apr 2024 17:35:08 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id ECD9E9DA; Tue, 30 Apr 2024 17:35:19 +0200 (CEST) Date: Tue, 30 Apr 2024 17:35:16 +0200 (CEST) From: Christian Ebner To: Proxmox Backup Server development discussion , Gabriel Goller Message-ID: <1861795139.12908.1714491316539@webmail.proxmox.com> In-Reply-To: References: <20240430133957.304866-1-c.ebner@proxmox.com> MIME-Version: 1.0 X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.6-Rev61 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.029 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [PATCH proxmox-backup] fix #2996: client: allow optional match pattens for restore X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox Backup Server development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pbs-devel-bounces@lists.proxmox.com Sender: "pbs-devel" > On 30.04.2024 17:19 CEST Gabriel Goller wrote: > > > Gave this a quick spin and it worked quite good! > > The only thing that didn't work was when I used '-' as a target, which > should print everything to stdout. When using it, the --matches > parameter is simply ignored and it dumps the whole archive on stdout. > E.g.: > > proxmox-backup-client restore --matches README.rst host/debian/2024-04-30T15:08:06Z test.pxar.didx - > > Not sure if this is in the scope of this patch or not though. > > If it isn't, you can consider: > > Tested-by: Gabriel Goller Thanks a lot for testing and good catch! This should indeed not be possible and I need to add a check to disallow this combination of the `matches` being set and the `target` being stdout. Will send a new version. Cheers, Chris _______________________________________________ pbs-devel mailing list pbs-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel