From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2880069E9D for ; Wed, 20 Jan 2021 19:20:53 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 112FFB6ED for ; Wed, 20 Jan 2021 19:20:23 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 537FEB6DD for ; Wed, 20 Jan 2021 19:20:21 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 209FA46097 for ; Wed, 20 Jan 2021 19:20:21 +0100 (CET) Date: Wed, 20 Jan 2021 19:20:12 +0100 (CET) From: =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= To: Dietmar Maurer , Proxmox Backup Server development discussion Message-ID: <1836395635.398.1611166813042@webmail.proxmox.com> In-Reply-To: <216794561.395.1611161949649@webmail.proxmox.com> References: <20210119120943.19363-1-dietmar@proxmox.com> <1611157977.5ji5ovitgo.astroid@nora.none> <216794561.395.1611161949649@webmail.proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.4-Rev16 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.027 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pbs-devel] [RFC proxmox-backup] add "password hint" to KeyConfig X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jan 2021 18:20:53 -0000 > Dietmar Maurer hat am 20.01.2021 17:59 geschrieben: > > > > does it make sense to split the "public" (misleading naming ;)) and > > private part in tape_encryption_keys.rs? it seems to me that we > > access/modify them together, so we might want to make it a single file > > to avoid running out of sync? i.e., EncryptionKeyInfo could just get the > > KeyConfig as field as well, and we store a list/map of those.. > > I have done the split to protect the private part (only accessible by root). > The public part can be accessed (and even modified (change password) by user backup). not sure whether that's appropriate - the KeyConfig part is just as well-protected as the user's password choice, so unless there is a reason why this *has* to be accessible by user backup I'd make it root only as well.. anything actually using the key needs to run as root anyhow, so the password change can as well.. there is no public (as in, I don't care who can access this) and private part. there is an unprotected and a semi-protected encoding of the same secret..