From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <f.gruenbichler@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id E08E49B116
 for <pbs-devel@lists.proxmox.com>; Mon, 20 Nov 2023 08:54:54 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id BA05E15010
 for <pbs-devel@lists.proxmox.com>; Mon, 20 Nov 2023 08:54:24 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS
 for <pbs-devel@lists.proxmox.com>; Mon, 20 Nov 2023 08:54:23 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 79DB943321
 for <pbs-devel@lists.proxmox.com>; Mon, 20 Nov 2023 08:54:23 +0100 (CET)
Date: Mon, 20 Nov 2023 08:54:22 +0100 (CET)
From: =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= <f.gruenbichler@proxmox.com>
To: Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>, 
 Thomas Lamprecht <t.lamprecht@proxmox.com>,
 Maximiliano Sandoval R <m.sandoval@proxmox.com>
Message-ID: <1810775013.20.1700466862839@webmail.proxmox.com>
In-Reply-To: <5e68f9a1-ed8a-4493-9162-b4e285fc2685@proxmox.com>
References: <20231117123739.157277-1-m.sandoval@proxmox.com>
 <20231117123739.157277-2-m.sandoval@proxmox.com>
 <5e68f9a1-ed8a-4493-9162-b4e285fc2685@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Priority: 3
Importance: Normal
X-Mailer: Open-Xchange Mailer v7.10.6-Rev54
X-Originating-Client: open-xchange-appsuite
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.065 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 DMARC_MISSING             0.1 Missing DMARC policy
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
 T_SCC_BODY_TEXT_LINE    -0.01 -
Subject: Re: [pbs-devel] [PATCH proxmox 1/2] sys: Use safe wrapper for
 libc::isatty
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Mon, 20 Nov 2023 07:54:54 -0000

> Thomas Lamprecht <t.lamprecht@proxmox.com> hat am 19.11.2023 16:09 CET geschrieben: 
>  
> Am 17/11/2023 um 13:37 schrieb Maximiliano Sandoval R:
> > Use the `std::io::IsTerminal` trait introduced in Rust 1.70.
> 
> ack, but a more general question: should we set the msrv in the manifest:
> 
> rust-version = "1.70"
> 
> We did not bothered to much with that until now, only a bit indirectly through
> increasing the edition to e.g., 2021, and we do not have that many external
> users for it to matter much.

I think that would make sense. most recent debcargo versions (not yet for us) translate this to the corresponding versioned dep, and the error messages are also much nicer and earlier in case somebody tries to build with a too old version..