From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2F17397F60 for ; Wed, 6 Mar 2024 16:13:37 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 109D71B0BA for ; Wed, 6 Mar 2024 16:13:37 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 6 Mar 2024 16:13:36 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CE341487DA for ; Wed, 6 Mar 2024 16:13:35 +0100 (CET) Date: Wed, 6 Mar 2024 16:13:35 +0100 (CET) From: Christian Ebner To: Proxmox Backup Server development discussion , Gabriel Goller Message-ID: <1800721063.9375.1709738015138@webmail.proxmox.com> In-Reply-To: <20240306143422.114335-1-g.goller@proxmox.com> References: <20240306143422.114335-1-g.goller@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.6-Rev59 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.040 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pbs-devel] [RFC proxmox-backup 0/3] Encode creation parameters into pxar archive X-BeenThere: pbs-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox Backup Server development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Mar 2024 15:13:37 -0000 > On 06.03.2024 15:34 CET Gabriel Goller wrote: > > > To better debug the creation of the pxar archive, we encode the > creation_params (the parameters passed to the cli) inside the pxar > archive. Like this we just need to locate the `.pxar_creation_params` > file in the archive and we can check which arguments have been used. > > To realize this, we unify all the parameters of the `create_backup` > function so that we don't need an additional struct (which in turn > introduces additional maintenance efforts). > > An example `.pxar_creation_params` file would look like this: > > { > "backupspec": [ > "test.pxar:linux" > ], > "chunk-size": 4096, > "exclude": [ > "MAINTAINERS" > ], > "skip-e2big-xattr": true > } > While this approach has already been used up until now for storing the pxar cli exclude patterns, allowing to encode such metadata inside the archive as regular file without having any means other than the filename to find and distinguish this information from other files seems not ideal to me. Wouldn't it make sense to extend the pxar file format by a dedicated entry type to store such information? And handle these entries in a dedicated manner? E.g. by a `PXAR_CLI_PARAMS` entry header? This would of course require an updated pxar format version 2, which we might need anyways if the patches regarding metadata based change detection should be applied. Cheers, Chris