From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id B357B1FF0A8 for ; Sat, 14 Nov 2026 22:27:59 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 3E785211F3; Sat, 14 Nov 2026 22:27:59 +0100 (CET) From: Thomas Lamprecht To: pbs-devel@lists.proxmox.com, Jakob-Tobias Winter Subject: applied: [PATCH proxmox-backup v2] bin: debug: api: fix panic on parameters given more than once Date: Sat, 14 Nov 2026 22:27:43 +0100 Message-ID: <179469166098.2392541.1117491661000343646.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261112101029.726398-2-tobias@stuttgart.de> References: <20261112101029.726398-2-tobias@stuttgart.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794691673312 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.233 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: LD3HXGD3K7PO3DWXEIXEZWTEXJIE7SJP X-Message-ID-Hash: LD3HXGD3K7PO3DWXEIXEZWTEXJIE7SJP X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 12 Nov 2026 11:10:30 +0100, Jakob-Tobias Winter wrote: > Array parameters, for example 'group-filter', are set by giving the > parameter once per value. The command line parser collects the values of > a repeated parameter in an array, while the 'api' subcommands expected a > single string for each parameter and panicked with "entered unreachable > code". So array parameters could only be passed with one value. > > Hand each value over to the parameter verification separately. Array > parameters now accept more than one value, and other parameters that are > given more than once get rejected as duplicate instead of causing a > panic. > > [...] Applied, thanks! [1/1] bin: debug: api: fix panic on parameters given more than once commit: 53a3e6289fd8b8211c93d8fb06472fdee7f4ff92