From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id D6D931FF0A8 for ; Sat, 14 Nov 2026 22:28:04 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id D2822215B2; Sat, 14 Nov 2026 22:28:00 +0100 (CET) From: Thomas Lamprecht To: pbs-devel@lists.proxmox.com, Christian Ebner Subject: applied: [PATCH proxmox-backup] api: gc: fix mismatched UPID and jobstate in GC status Date: Sat, 14 Nov 2026 22:27:42 +0100 Message-ID: <179469166097.2392541.7821447570565349437.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261113081627.43740-1-c.ebner@proxmox.com> References: <20261113081627.43740-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794691673209 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.234 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: TMGGDEIF5UWAHSVCSKKAY42X2FKXNTKC X-Message-ID-Hash: TMGGDEIF5UWAHSVCSKKAY42X2FKXNTKC X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 13 Nov 2026 09:16:27 +0100, Christian Ebner wrote: > garbage_collection_status_unchecked() gathers information from two > locations, the .gc-status as well as the job state file. > The former is written only on successful garbage collection runs, > the latter on every run, including failed ones. > > Collecting the status incorrectly mixed the information from both, > leading to comparison of timestamps from two different runs, which > caused incorrect or negative durations. Further, missing a > .gc-status UPID dropped last-run endtimes and states completely. > > [...] Applied, thanks! [1/1] api: gc: fix mismatched UPID and jobstate in GC status commit: b743599749d76f34b92c6a21d1bb62477a8c0fda