From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 264CC1FF0B3 for ; Wed, 11 Nov 2026 23:02:51 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id E21F321666; Wed, 11 Nov 2026 23:02:49 +0100 (CET) From: Thomas Lamprecht To: pbs-devel@lists.proxmox.com, "Max R. Carrara" Subject: applied: [PATCH proxmox v3 0/5] Fix #6738: Improve TLS Handshake Handling & Error Logging Date: Wed, 11 Nov 2026 23:00:48 +0100 Message-ID: <179443424575.1210260.12360526617961021704.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261110110728.144880-1-m.carrara@proxmox.com> References: <20261110110728.144880-1-m.carrara@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794434564941 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.140 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) KAM_LOTSOFHASH 0.25 Emails with lots of hash-like gibberish RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: S6UJB75ECFLDSOGDSMKZB2QWGGCMPLFZ X-Message-ID-Hash: S6UJB75ECFLDSOGDSMKZB2QWGGCMPLFZ X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 10 Nov 2026 12:07:22 +0100, Max R. Carrara wrote: > Fix #6738: Improve TLS Handshake Handling & Error Logging - v3 > ============================================================== > > This is a slightly bigger refresh of an older patch (see below) that > reduces the noisiness of TLS handshake errors, in particular when health > checks are only opening and closing connections without sending any > data. > > [...] Applied, thanks! The code was applied as is, I only trimmed some commit messages a tiny bit while trying hard to keep all relevant info in there. On top I added a regression test for the case that patch 4/5 fixes, it provokes the repeated readiness over a real local connection by filling the server side's send buffer after the client sent two bytes and letting the client drain it again. It fails deterministically on the old code and passes with your fix. [1/5] rest-server: connection: use enum for TLS handshake check result commit: f2468d9a1c9419916172c0450466cb110411ceab [2/5] rest-server: connection: add tests for TLS handshake check commit: 2b0e24cb81f289f4840929057318841e6ca07043 [3/5] rest-server: connection: log cause of TLS handshake check errors commit: 96e7808d4fac5b3c4d3676a51aab8f2cb8716a87 [4/5] rest-server: connection: avoid dropping clients during TLS check commit: b595e9255eefedf7861c8de9ae2500f6b27a5fcd [5/5] fix #6738: rest-server: log early closed connections at debug level commit: 519aecad93f5c881c6aa615b93017bf0daf3fa10