From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 0F8FC1FF0B4 for ; Tue, 10 Nov 2026 17:36:12 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id B28B921618; Tue, 10 Nov 2026 17:36:11 +0100 (CET) From: Thomas Lamprecht To: pbs-devel@lists.proxmox.com, Jakob-Tobias Winter Subject: applied: [PATCH proxmox-backup] fix #7964: tape: make barcode-label task abortable Date: Tue, 10 Nov 2026 17:35:59 +0100 Message-ID: <179432855654.4055929.8911794378494677210.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261106093422.1637066-2-tobias@stuttgart.de> References: <20261106093422.1637066-2-tobias@stuttgart.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794328568573 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.270 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 6TXZNJWNCOOV677L7QAPTQMP6RIXADTY X-Message-ID-Hash: 6TXZNJWNCOOV677L7QAPTQMP6RIXADTY X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 06 Nov 2026 10:33:22 +0100, Jakob-Tobias Winter wrote: > The barcode-label-media worker never checked whether an abort was > requested, so pressing stop in the GUI had no effect and the task kept > loading and labeling every unlabeled tape in the changer. > > Check for an abort request before each tape is loaded, and again before > the label is written, since loading the media can take a while. A load > or label write that is already running cannot be interrupted, so those > operations still run to completion. > > [...] Applied, thanks! [1/1] fix #7964: tape: make barcode-label task abortable commit: dc399a3fdf4a5ceb3be74ea191a482c7db950aed