From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 34EE11FF0B3 for ; Wed, 28 Oct 2026 20:49:06 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 8FEA520BEE; Wed, 28 Oct 2026 20:49:05 +0100 (CET) From: Thomas Lamprecht To: pbs-devel@lists.proxmox.com, Robert Obkircher Subject: applied: [PATCH v2 proxmox-backup 0/2] minor chunk insert improvements Date: Wed, 28 Oct 2026 20:48:53 +0100 Message-ID: <179321686592.2278586.10060588975655269347.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260812135843.236667-1-r.obkircher@proxmox.com> References: <20260812135843.236667-1-r.obkircher@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793216941369 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.453 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: JO23GZEUK6WR6VWHG3AFVST2FSOOWFBV X-Message-ID-Hash: JO23GZEUK6WR6VWHG3AFVST2FSOOWFBV X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 12 Aug 2026 15:58:36 +0200, Robert Obkircher wrote: > Improve error messages and avoid custom unsafe code. > > Changes since [v1]: > * improve error messages as suggested by @Chris > * mention "magic number" > * reprase to "verify and garbage-collect" > > [...] Applied, thanks! [1/2] datastore: prefer standard library over custom unsafe code commit: 0182eefa0ab08b8f6699bfa86ff9fb2f13940671 [2/2] datastore: rephrase error messages for failed chunk insert commit: f65ccf15ee17f0b5dccb8acac57a4738ef179af6