From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pbs-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40])
	by lore.proxmox.com (Postfix) with ESMTPS id E6DE11FF130
	for <inbox@lore.proxmox.com>; Thu, 06 Aug 2026 15:27:45 +0200 (CEST)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id 0725C21533;
	Thu, 06 Aug 2026 15:27:49 +0200 (CEST)
Date: Thu, 06 Aug 2026 15:27:43 +0200
From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= <f.gruenbichler@proxmox.com>
Subject: applied: [PATCH proxmox-backup v3 10/16] notifications: use
 `Severity::Error` for acme renewal failures
To: pbs-devel@lists.proxmox.com, Shannon Sterz <s.sterz@proxmox.com>
References: <20260805155308.519896-2-s.sterz@proxmox.com>
	<20260805155308.519896-12-s.sterz@proxmox.com>
In-Reply-To: <20260805155308.519896-12-s.sterz@proxmox.com>
MIME-Version: 1.0
User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid)
Message-Id: <1786022859.dimv9itska.astroid@yuna.none>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1786022852043
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.106 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_LOW        -0.7 Sender listed at https://www.dnswl.org/,
 low trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: C2V5N4GFKIQ3FWMAKQPK7RLMOPOGQWQY
X-Message-ID-Hash: C2V5N4GFKIQ3FWMAKQPK7RLMOPOGQWQY
X-MailFrom: f.gruenbichler@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pbs-devel-owner@lists.proxmox.com>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Subscribe: <mailto:pbs-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pbs-devel-leave@lists.proxmox.com>

On August 5, 2026 5:53 pm, Shannon Sterz wrote:
> users should not miss such renewal failures as it could lead to
> failing backups. so increase the severity.
>=20
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
>  src/server/notifications/mod.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/src/server/notifications/mod.rs b/src/server/notifications/m=
od.rs
> index 487975582..db7df7e00 100644
> --- a/src/server/notifications/mod.rs
> +++ b/src/server/notifications/mod.rs
> @@ -566,7 +566,7 @@ pub fn send_certificate_renewal_mail(result: &Result<=
(), Error>) -> Result<(), E
>      };
> =20
>      let notification =3D Notification::from_template(
> -        Severity::Info,
> +        Severity::Error,
>          "acme-err",
>          serde_json::to_value(template_data)?,
>          metadata,
> --=20
> 2.47.3
>=20
>=20
>=20
>=20
>=20
>=20