From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 5306A1FF0F0 for ; Mon, 03 Aug 2026 14:26:08 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 0F975213BC; Mon, 03 Aug 2026 14:26:08 +0200 (CEST) From: =?UTF-8?q?Fabian=20Gr=C3=BCnbichler?= To: pbs-devel@lists.proxmox.com, Christian Ebner Subject: applied: [PATCH proxmox-backup] fix #7878: reuse manifest on non-encrypting push with matching key Date: Mon, 3 Aug 2026 14:25:51 +0200 Message-ID: <178575993732.501771.15160762139300015009.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260803102458.371169-1-c.ebner@proxmox.com> References: <20260803102458.371169-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1785759954536 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.128 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: R665CPCGKJZGRSZIKRKHZIPDFCKIJRLV X-Message-ID-Hash: R665CPCGKJZGRSZIKRKHZIPDFCKIJRLV X-MailFrom: f.gruenbichler@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Mon, 03 Aug 2026 12:24:57 +0200, Christian Ebner wrote: > This fixes a regression for push sync jobs with pre-encrypted > snapshots no longer reusing chunks, even if the previous backup > snapshot was encrypted using the same key. > > Previous to commit bb3a5fdfc ("sync: push: gracefully handle previous > manifest signature mismatches") the it was possible to reuse the > manifest of a previous backup snapshot even if not matched by the > key fingerprint. The newly introduced check restricted this, did > however not take into account that for pre-encrypted snapshots the > crypt config on the push is not present, therefore acting like a > regular (non-encrypting) push. In that case, there is no encryption > key with matching fingerprint to check, so the job did not allow to > reuse chunks from that manifest, resulting in prolonged sync runs. > > [...] Applied, thanks for the fast fix! [1/1] fix #7878: reuse manifest on non-encrypting push with matching key commit: d42f77babadedafaec66dcca680ceca91e8dd389 Best regards, -- Fabian Grünbichler