From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id C226C1FF138 for ; Tue, 21 Jul 2026 14:51:39 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id BF65F214B0; Tue, 21 Jul 2026 14:51:38 +0200 (CEST) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: Re: [PATCH proxmox-backup v4 01/15] bin: api/proxy: early init proxmox-product-config From: Robert Obkircher To: Christian Ebner In-Reply-To: <20260720141605.728096-2-c.ebner@proxmox.com> References: <20260720141605.728096-1-c.ebner@proxmox.com> <20260720141605.728096-2-c.ebner@proxmox.com> Date: Tue, 21 Jul 2026 14:51:31 +0200 Message-Id: <178463829185.236029.2997841847859378199.b4-review@b4> X-Mailer: b4 0.16-dev X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1784638268045 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.270 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_LOW -0.7 Sender listed at https://www.dnswl.org/, low trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 5JVHJGHW3WUMXHV7SAFEMBDD3BXETWH3 X-Message-ID-Hash: 5JVHJGHW3WUMXHV7SAFEMBDD3BXETWH3 X-MailFrom: r.obkircher@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pbs-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: > diff --git a/src/bin/proxmox-backup-proxy.rs b/src/bin/proxmox-backup-proxy.rs > index eb5443992..35b1f774f 100644 > --- a/src/bin/proxmox-backup-proxy.rs > +++ b/src/bin/proxmox-backup-proxy.rs > @@ -185,10 +185,11 @@ async fn run() -> Result<(), Error> { > .tasklog_pbs() > .init()?; > > + proxmox_product_config::init(pbs_config::backup_user()?, pbs_config::priv_user()?); > + It might be better to move this to the main function to have all of the backup user logic in one place. -- Robert Obkircher