From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 9CA1B1FF14C for ; Fri, 29 May 2026 12:23:06 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 492647395; Fri, 29 May 2026 12:23:06 +0200 (CEST) From: Thomas Lamprecht To: pbs-devel@lists.proxmox.com, Robert Obkircher Subject: applied: [PATCH v1 proxmox-backup] api: do not block tokio worker threads during chunk inserts Date: Fri, 29 May 2026 12:22:26 +0200 Message-ID: <178005014240.352694.11884632493213318223.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260527123809.238964-1-r.obkircher@proxmox.com> References: <20260527123809.238964-1-r.obkircher@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1780050123466 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.005 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ZXOYZLHUVXS5EPVWIMDP2YWPOQEYHJTC X-Message-ID-Hash: ZXOYZLHUVXS5EPVWIMDP2YWPOQEYHJTC X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 27 May 2026 14:37:51 +0200, Robert Obkircher wrote: > Move synchronous operations off the worker threads to prevent blocking > the I/O and timer drivers of the entire runtime. This is especially > important for S3 uploads, which wait up to 3 hours for the chunk lock. > > Also prevent worker starvation, which could happen because S3 uploads > are wrapped in proxmox_async::runtime::block_on, which prevents other > futures from running in the current thread. > > [...] Applied, thanks! [1/1] api: do not block tokio worker threads during chunk inserts commit: 23400016322c7a6981f111558e8d22666e32ee8c