From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 6EC5D1FF146 for ; Tue, 28 Apr 2026 20:12:15 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 44B281A2F2; Tue, 28 Apr 2026 20:12:15 +0200 (CEST) From: Thomas Lamprecht To: pbs-devel@lists.proxmox.com, Christian Ebner Subject: applied: [PATCH proxmox-backup] sync: rename change-detection-fingerprint to sync-source-signature Date: Tue, 28 Apr 2026 20:11:32 +0200 Message-ID: <177739988818.1498991.3876506656748367562.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260428143642.1012584-1-c.ebner@proxmox.com> References: <20260428143642.1012584-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777399804000 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: INYTC6JZ7PUQ6WBLYXJR2QUOPBOFOMV3 X-Message-ID-Hash: INYTC6JZ7PUQ6WBLYXJR2QUOPBOFOMV3 X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Tue, 28 Apr 2026 16:36:42 +0200, Christian Ebner wrote: > Introduced in 87a819311 ("datastore: manifest: add helper for change > detection fingerprint") the name was found to be confusion due to > the potential metal clash with the totally unrelated client parameter > named `change-detecton-mode`, especially in log output. > > The new field name `sync-source-signature` better reflects that this > is the signature of the sync source snapshot stored on the target. > The previous field is kept for backwards compatibility with already > synced snapshots storing the field, the methods, comments and log > messages all updated accordingly. > > [...] Applied, thanks! [1/1] sync: rename change-detection-fingerprint to sync-source-signature commit: ca5e9e46bcb8b411522e851907c900a10ee9e9cd