From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 803E41FF143 for ; Sat, 25 Apr 2026 21:40:07 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 63A863A58; Sat, 25 Apr 2026 21:40:07 +0200 (CEST) From: Thomas Lamprecht To: pbs-devel@lists.proxmox.com, Christian Ebner Subject: applied: [PATCH proxmox-backup 0/3] fixup client log fetching and decryption Date: Sat, 25 Apr 2026 21:37:25 +0200 Message-ID: <177714584411.2472936.17244011036690851535.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260425140927.928214-1-c.ebner@proxmox.com> References: <20260425140927.928214-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777145844792 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: TZG7Y6TLHU5L3WGNADLF5L57P3ZRBH5M X-Message-ID-Hash: TZG7Y6TLHU5L3WGNADLF5L57P3ZRBH5M X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Sat, 25 Apr 2026 16:09:24 +0200, Christian Ebner wrote: > This patches fix a few issues with the client log fetching for pull > sync jobs: > 1. Local pull syncs did not fetch the client log at all, add the > missing implementation thereof. > 2. While fetching the client log, some logs were still not using the > log line sender, required since introduction of the parallel group > sync feature for correctly buffering and logging lines with prefix. > 3. The client log was fetched without decryption even with a matching > decryption key. This is fixed by factoring out the data blob > decryption logic into a reusable helper function and using it in > combination with the crypt config to decrypt the blobs while > fetching the client log. > > [...] Applied, thanks! Made two follow-ups though: ea86e2697 sync: pull: remove encrypted client log temp file after decrypt 68668ba53 sync: pull: skip local client log fetch when source lacks one [1/3] sync: fix client log fetching for local sync job commit: c456d58a4212173d050b0d5796bef65588bf86d7 [2/3] sync: use log sender for logging when fetching client log commit: 2d4d0bf6b14621ea0deb402221e31e8e18c1bf6b [3/3] sync: decrypt client log on pull with matching decryption key commit: e5b191109222b1b8f3abbbd7d73633bd0b42df25