From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id EE17D1FF143 for ; Sat, 25 Apr 2026 14:03:12 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B01B227FB6; Sat, 25 Apr 2026 14:03:12 +0200 (CEST) From: Thomas Lamprecht To: pbs-devel@lists.proxmox.com, Christian Ebner Subject: applied: [PATCH proxmox-backup] sync: pull: fix double blob decoding when decrypting Date: Sat, 25 Apr 2026 14:02:33 +0200 Message-ID: <177711854904.1328848.1646492817261116195.b4-ty@b4> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260425101015.437816-1-c.ebner@proxmox.com> References: <20260425101015.437816-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777118466597 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.003 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: DPEYHJX6HYXHHVTIDESS7YRJDBQOL74R X-Message-ID-Hash: DPEYHJX6HYXHHVTIDESS7YRJDBQOL74R X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Sat, 25 Apr 2026 12:10:15 +0200, Christian Ebner wrote: > Commit 2f94320db ("sync: pull: decrypt blob files on pull if > encryption key is configured") introduced the logic to decrypt > encrypted data blob contents from the source on the fly when pulling > with a matching decryption key. > > This however incorrectly performs a double blob decoding, as the > DataBlobReader already checks and strips the header while reading the > raw data from file, the DataBlob::load_from_reader() therefore > chocking when trying to check the now missing header. > > [...] Applied, thanks! [1/1] sync: pull: fix double blob decoding when decrypting commit: beafc2f0b06680acd6c860e76f411e63e9438a91