From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 05B5D1FF140 for ; Fri, 24 Apr 2026 10:37:17 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id D5CECF6D7; Fri, 24 Apr 2026 10:37:16 +0200 (CEST) Date: Fri, 24 Apr 2026 10:37:07 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= Subject: Re: [PATCH proxmox-backup v2] acme: partially fix #6372: scale certificate renewal checks by lifetime To: Manuel Federanko , pbs-devel@lists.proxmox.com References: <20260423134607.105229-2-m.federanko@proxmox.com> In-Reply-To: <20260423134607.105229-2-m.federanko@proxmox.com> MIME-Version: 1.0 User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid) Message-Id: <1777019789.wslwp6i17e.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777019740565 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.055 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [letsencrypt.org,proxmox.com] Message-ID-Hash: 34LCYHTHR7J7LTLMB6ZFYRAMVKUOEHTY X-Message-ID-Hash: 34LCYHTHR7J7LTLMB6ZFYRAMVKUOEHTY X-MailFrom: f.gruenbichler@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: seems like v1 of this got applied (with some follow-ups), would you mind checking if rebasing the diff between v1 and v2 still makes sense? On April 23, 2026 3:46 pm, Manuel Federanko wrote: > Start renewing a certificate once 2/3 or 1/2 (for short-lived > certificates) of its total lifetime have passed, instead of the > hardcoded 30 days. This stays consistent with many certificates, which > are valid for 90 days and is recommended by letsencrypt [1]. >=20 > The update service runs daily, impose a 3 day minimum remaining lifetime > to still be able to handle transient failures for certificate renewals. >=20 > [1] https://letsencrypt.org/docs/integration-guide/#when-to-renew >=20 > Signed-off-by: Manuel Federanko > Fixes: https://bugzilla.proxmox.com/show_bug.cgi?id=3D6372