From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 344BA1FF140 for ; Fri, 24 Apr 2026 10:32:06 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 13BE1F262; Fri, 24 Apr 2026 10:32:06 +0200 (CEST) Date: Fri, 24 Apr 2026 10:31:32 +0200 From: Fabian =?iso-8859-1?q?Gr=FCnbichler?= Subject: Re: applied: [PATCH proxmox-backup v8 00/13] fixes #6195: add support for moving groups and namespaces To: Hannes Laimer , pbs-devel@lists.proxmox.com, Thomas Lamprecht References: <20260422133951.192862-1-h.laimer@proxmox.com> <177698386728.726567.11620419590194139855.b4-ty@b4> In-Reply-To: <177698386728.726567.11620419590194139855.b4-ty@b4> MIME-Version: 1.0 User-Agent: astroid/0.17.0 (https://github.com/astroidmail/astroid) Message-Id: <1777018910.mv34jbslq9.astroid@yuna.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1777019405487 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.055 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: MO2QF6Y7S2ACNV2RJNEDQDZQLPXK4IZP X-Message-ID-Hash: MO2QF6Y7S2ACNV2RJNEDQDZQLPXK4IZP X-MailFrom: f.gruenbichler@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On April 24, 2026 12:38 am, Thomas Lamprecht wrote: > On Wed, 22 Apr 2026 15:39:38 +0200, Hannes Laimer wrote: >> Add support for moving backup groups and entire namespace subtrees to >> a different location within the same datastore. >>=20 >> Groups are moved with exclusive per-group and per-snapshot locking. >> For S3, objects are copied to the target prefix before deleting the >> source. Namespace moves process groups individually, deferring and >> retrying lock conflicts once, so partially failed moves can be >> completed with move-group. >>=20 >> [...] >=20 > Applied, thanks! >=20 > Squashed in the relatively trivial fixes for what Michael found, but I re= ally > could not find any issue with locking after multiple looks, so either tha= t came > from some side effect in testing or we'd need more info for a good reprod= ucer. I can reproduce this easily, and the cause is that the proxmox-backup-manager CLI handlers directly execute the API endpoints, instead of going via the proxy.. that causes some parent dirs in the locking hiearchy to have the wrong ownership (755 root:root instead of 755 backup:backup), which then turns into failed to delete snapshot - Error { context: "while destroying snapshot \'B= ackupDir { store: \"test\", ns: BackupNamespace { inner: [\"foobar\"], len:= 7 }, dir: BackupDir { group: BackupGroup { ty: Host, id: \"bookworm\" }, t= ime: 1674040234 }, backup_time_string: \"2023-01-18T11:10:34Z\" }\'", sourc= e: Error { context: "unable to acquire snapshot lock \"/run/proxmox-backup/= locks/test/foobar/host-bookworm-2023\\\\x2d01\\\\x2d18T11\\\\x3a10\\\\x3a34= Z\"", source: "mkstemp \"/run/proxmox-backup/locks/test/foobar/host-bookwor= m-2023\\\\x2d01\\\\x2d18T11\\\\x3a10\\\\x3a34Z.tmp_XXXXXX\" failed: EACCES:= Permission denied", }, } (400) because it's not possible for the user backup to create new lock files in that directory.. cleared by a reboot or recursive chown, and fixed by either moving those commands to the client, or letting manager connect to the API. it's also a bit weird that - create namespace - list namespaces - delete namespace for namespaces are all in proxmox-backup-client, but moving a namespace is only available in proxmox-backup-manager which lacks all of the above.. similarly, interactions with groups are in the client: - create snapshot (and thus implictly groups) - forget snapshots by pruning a group - forget individual snapshots - forgetting a whole group - listing snapshots (and thus groups) - changing group ownership but moving a group is only available in proxmox-backup-manager again, which has no other group-level commands AFAICT?