From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dietmar@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id 6FB176C240
 for <pbs-devel@lists.proxmox.com>; Fri, 29 Jan 2021 09:18:12 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id 615B4C826
 for <pbs-devel@lists.proxmox.com>; Fri, 29 Jan 2021 09:18:12 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [212.186.127.180])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS id EE67BC818
 for <pbs-devel@lists.proxmox.com>; Fri, 29 Jan 2021 09:18:11 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id B7E1546161
 for <pbs-devel@lists.proxmox.com>; Fri, 29 Jan 2021 09:18:11 +0100 (CET)
Date: Fri, 29 Jan 2021 09:17:51 +0100 (CET)
From: Dietmar Maurer <dietmar@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>,
 Proxmox Backup Server development discussion <pbs-devel@lists.proxmox.com>
Message-ID: <1776986966.1276.1611908272501@webmail.proxmox.com>
In-Reply-To: <5fc24404-3cbb-71ca-a2a4-c989281b85c2@proxmox.com>
References: <20210126101702.28778-1-d.csapak@proxmox.com>
 <898932613.1270.1611900339022@webmail.proxmox.com>
 <5fc24404-3cbb-71ca-a2a4-c989281b85c2@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-Priority: 3
Importance: Normal
X-Mailer: Open-Xchange Mailer v7.10.4-Rev16
X-Originating-Client: open-xchange-appsuite
X-SPAM-LEVEL: Spam detection results:  0
 AWL 0.118 Adjusted score from AWL reputation of From: address
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pbs-devel] [PATCH proxmox-backup v2] api2/reader: asyncify the
 reader worker task
X-BeenThere: pbs-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox Backup Server development discussion
 <pbs-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pbs-devel/>
List-Post: <mailto:pbs-devel@lists.proxmox.com>
List-Help: <mailto:pbs-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pbs-devel>, 
 <mailto:pbs-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Fri, 29 Jan 2021 08:18:12 -0000


> On 01/29/2021 8:01 AM Dominik Csapak <d.csapak@proxmox.com> wrote:
> 
>  
> On 1/29/21 7:05 AM, Dietmar Maurer wrote:
> > Why did you change the _guard lifetime?
> 
> how so?
> 
> before this patch the guard was moved to the 'map' closure of
> the future::select call
> so it did go out of scope after either future (req_fut, abort_future) 
> resolved
> 
> now i moved it in the async move block of the worker, and goes out of
> scope after the future resolves

OK, I can see it now - will apply the patch.