From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 18B261FF140 for ; Fri, 10 Apr 2026 02:49:00 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 42D43EEA0; Fri, 10 Apr 2026 02:49:44 +0200 (CEST) From: Thomas Lamprecht To: pbs-devel@lists.proxmox.com, Christian Ebner Subject: applied: [PATCH proxmox-backup v8 00/17] partially fix #6563: add s3 counter for statistics and notifications Date: Fri, 10 Apr 2026 02:49:07 +0200 Message-ID: <177578214248.2697034.10511094955518196902.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260402105333.463088-1-c.ebner@proxmox.com> References: <20260402105333.463088-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775782110233 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.124 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LOTSOFHASH 0.25 Emails with lots of hash-like gibberish RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: XXNYMZPT3ALK7ICTJBHE7OO4MD2I5O2E X-Message-ID-Hash: XXNYMZPT3ALK7ICTJBHE7OO4MD2I5O2E X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Thu, 02 Apr 2026 12:53:16 +0200, Christian Ebner wrote: > This patch series implements request and traffic counters for the s3 > client, being shared as atomic counters via shared memory and mmapping > across all s3-client instances. > > The shared counters are instantiated on demand for individual > datastores with s3 backend on s3 client instantiation and stored as > part of the datastore implementation by loading the mmapped file on > datastore creation, being cached for further access. Counter threshold > values can be defined in the datastore options, allowing to send > notifications via the notification system if counters exceeded the set > threshold values. Further, a per-datastore schedule can be configured > to reset the counters with given interval. > > [...] Applied, with a few follow-ups that should address your own and Dominik findings, thanks! [01/17] api: s3: add endpoint to reset s3 request counters commit: b1ad47ff8c70cd37cd6a47760c19c938fb857fe1 [02/17] bin: s3: expose request counter reset method as cli command commit: aa25261a4404987759ae394cd860431a1f33da98 [03/17] ui: datastore summary: move store to be part of summary panel commit: d65adbdb193fb817f2c3ee50dc0a7e5c44a00659 [04/17] ui: expose s3 request counter statistics in the datastore summary commit: 3e65758d43c3a04b4aeed20631c5f697edd777a4 [05/17] metrics: collect s3 datastore statistics as rrd metrics commit: f07cce815fd5c8be1ded15bde6cdeae1a21d8234 [06/17] api: admin: expose s3 statistics in datastore rrd data commit: 2dc9be41a9d03b20813ed2b670e5253ef091279d [07/17] partially fix #6563: ui: expose s3 rrd charts in datastore summary commit: c0cfbd08de6d07e9b64211f3684f7e7ff763982c [08/17] datastore: refactor datastore lookup parameters into dedicated type commit: e426e2f090d0bd2ab3cba3939e1218f71b8e83a1 [09/17] api: config: update notification thresholds for config and counters commit: d508cbc2b8c86eb37a40df48383f06750985c6f9 [10/17] ui: add notification thresholds edit window commit: 8b8876fcabf4a8f61076186aa20d587c8cb08dc1 [11/17] notification: define templates and template data for thresholds commit: 261b83d9631e68c68e1b5a5a9af158ee15d5f2c9 [12/17] datastore: add thresholds notification callback on datastore lookup commit: d63b825979f5d28879cefb99ab1026913319c8eb [13/17] api/ui: notifications: add 'thresholds' as notification type value commit: 3f843d2698fbf0f6f4f99b0d72d9c79732e9236d [14/17] api: config: allow counter reset schedule editing commit: a5ddd2b968901fe2aecf1dd2d206a9a37339a757 [15/17] ui: expose counter reset schedule edit window commit: 6696c779ae6a3daccab338ced6d780cedbbf35d1 [16/17] bin: proxy: periodically schedule counter reset task commit: 3f6d96fd547dbc9beaa6656b5e611ff316ae9aa7 [17/17] ui: add task description for scheduled counter reset commit: 0c25deb1bdf14de989c9f96ea5b1f56ad366cdb8