From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id 3E0461FF135 for ; Sun, 05 Apr 2026 11:11:40 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B3AF018B25; Sun, 5 Apr 2026 11:12:12 +0200 (CEST) From: Thomas Lamprecht To: pbs-devel@lists.proxmox.com, Christian Ebner Subject: applied: [PATCH proxmox{,-backup} v4 0/8] fix #6716: Add support for http proxy configuration for S3 endpoints Date: Sun, 5 Apr 2026 11:09:08 +0200 Message-ID: <177538014549.2644371.18338634086076668705.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260327121319.628881-1-c.ebner@proxmox.com> References: <20260327121319.628881-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775380237275 X-SPAM-LEVEL: Spam detection results: 0 AWL -0.123 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LOTSOFHASH 0.25 Emails with lots of hash-like gibberish SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: AVFLV3BGTQOOBA5UZWFX4AL3F2RNQBNP X-Message-ID-Hash: AVFLV3BGTQOOBA5UZWFX4AL3F2RNQBNP X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Fri, 27 Mar 2026 13:13:11 +0100, Christian Ebner wrote: > This patch series exposes the nodes proxy config setting to the S3 > clients for datastores backed by an S3 object store. > > To honor crate boundaries, the proxy configuration is refactored to > be part of pbs-config instead of proxmox-backup. The API types are > move to pbs-api-types, inlining proxmox_backup::tools::config::from_property_string() > and NodeConfig::validate() to do so without creating additional unwanted > dependencies. The schema definition for the proxy is moved to proxmox-http > instead, already containing the proxy config definition. > > [...] Applied, with the trivial context merge conflict from the S3 counter series resolved, thanks! btw. I fixed up the s/call side/call site/ typo that was present in three commit messages. [1/6] pbs-config: use http proxy schema moved to proxmox-http crate commit: 9759277cc6cd6d0c8fc28aecced4f6ccdefe34d9 [2/6] config: inline NodeConfig::validate() to its only call side commit: 28f6a7134d9eb2bec8495407aa7d69f8d194c2f6 [3/6] config: use moved NodeConfig definitions in pbs-api-types commit: 6279216832c6c3a520e656f3641d141b247c5561 [4/6] tools: drop unused from_property_string() helper commit: ff149a6a3faf78e61d057e9dcaa3f3d5966cbae7 [5/6] config: move node config into pbs-config, including helper tools commit: 6a6bd6143dfe7014ab5dc2dc3aae4bee32098df6 [6/6] fix #6716: pass node http proxy config to s3 backend commit: fbf8d1b250113e8c754aeae807fe3c78a95c3101