From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id ED15B1FF13C for ; Thu, 02 Apr 2026 00:46:14 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 6BDD6292A; Thu, 2 Apr 2026 00:46:43 +0200 (CEST) From: Thomas Lamprecht To: pbs-devel@lists.proxmox.com, Christian Ebner Subject: applied: [PATCH proxmox{,-backup} v7 00/34] partially fix #6563: add s3 counter for statistics and notifications Date: Thu, 2 Apr 2026 00:44:53 +0200 Message-ID: <177508347902.4061954.10077129733884666476.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260401134817.926499-1-c.ebner@proxmox.com> References: <20260401134817.926499-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775083541992 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.625 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LOTSOFHASH 0.25 Emails with lots of hash-like gibberish RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: V27DOPYCM5635FKEHJJM44HKMB2JXF4Q X-Message-ID-Hash: V27DOPYCM5635FKEHJJM44HKMB2JXF4Q X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 01 Apr 2026 15:47:43 +0200, Christian Ebner wrote: > This patch series implements request and traffic counters for the s3 > client, being shared as atomic counters via shared memory and mmapping > across all s3-client instances. > > The shared counters are instantiated on demand for individual > datastores with s3 backend on s3 client instantiation and stored as > part of the datastore implementation by loading the mmapped file on > datastore creation, being cached for further access. Counter threshold > values can be defined in the datastore options, allowing to send > notifications via the notification system if counters exceeded the set > threshold values. Further, a per-datastore schedule can be configured > to reset the counters with given interval. > > [...] Applied first few patches to keep this building with latest crate versions, thanks! Rest looks quite good too, a new version with the UI improvements I mentioned on/offlist and potentially taking a look into why the download stat counter seems off in my setup while the RRD metrics look alright. [01/23] metrics: split common module imports into individual use statements commit: cd2b3cb85d5c7c8131d5863d7564784d61a01e2f [02/23] ui: improve variable name indirectly fixing typo commit: dd4f81e4f0d338a503042537c53d459aa98b15c9 [03/23] notifications: template data: fix typos in docstrings commit: bd9040a814d37d63848b631e42730db215b180a2 [04/23] datastore: collect request statistics for s3 backed datastores commit: 6f7b8ce736a96db76aceb5107b675ebb52e18e95 [05/23] datastore: expose request counters for s3 backed datastores commit: 322d8a1863f72af1590c440bd1ab4de613aeb1cb Skipped the rest for now.