From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 39F281FF13A for ; Thu, 02 Apr 2026 00:20:45 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id DADA72674; Thu, 2 Apr 2026 00:21:13 +0200 (CEST) From: Thomas Lamprecht To: pbs-devel@lists.proxmox.com, Christian Ebner Subject: partially-applied: [PATCH proxmox{,-backup} v7 00/34] partially fix #6563: add s3 counter for statistics and notifications Date: Thu, 2 Apr 2026 00:20:06 +0200 Message-ID: <177507999875.3960019.3440407463791605794.b4-ty@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260401134817.926499-1-c.ebner@proxmox.com> References: <20260401134817.926499-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1775081979970 X-SPAM-LEVEL: Spam detection results: 0 AWL -1.626 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment KAM_LOTSOFHASH 0.25 Emails with lots of hash-like gibberish RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 1 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 3G3SIF3YXGFHPAS46UMLXAD4OPZEFUZE X-Message-ID-Hash: 3G3SIF3YXGFHPAS46UMLXAD4OPZEFUZE X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox Backup Server development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, 01 Apr 2026 15:47:43 +0200, Christian Ebner wrote: > This patch series implements request and traffic counters for the s3 > client, being shared as atomic counters via shared memory and mmapping > across all s3-client instances. > > The shared counters are instantiated on demand for individual > datastores with s3 backend on s3 client instantiation and stored as > part of the datastore implementation by loading the mmapped file on > datastore creation, being cached for further access. Counter threshold > values can be defined in the datastore options, allowing to send > notifications via the notification system if counters exceeded the set > threshold values. Further, a per-datastore schedule can be configured > to reset the counters with given interval. > > [...] Applied and rolled out the proxmox workspace parts, thanks! [01/11] s3-client: add persistent shared request counters for client commit: 363915aefda447d06712d297b397b15f6fab3f20 [02/11] s3-client: add counters for upload/download traffic commit: 6b08de93d152ecc04e550f014e72b81449fc3df6 [03/11] s3-client: account for upload traffic on successful request sending commit: c1d201b0bdab05168da4cfd9d5f702fe4257ae68 [04/11] s3-client: account for downloaded bytes in incoming response body commit: 3237d09e970f1b4d4ee7675dac254b6d333258dd [05/11] s3-client: request counters: periodically persist counters to file commit: d8f42b087222e3ea8d7c8de04b1d9d4e157177f6 [06/11] s3-client: sync flush request counters on client instance drop commit: 2ecd7e7b0f1f0b7b65c324dde078fe3f48cad03b [07/11] s3-client: api-types: define request counter thresholds commit: f624abd82892705c80e59a39dd05170c7d4ecfda [08/11] s3-client: implement request counter threshold and exceeding callback commit: 6b49d130237f4cdfcd6cfc8f68f863eb2728f4ad [09/11] pbs-api-types: define api type for s3 request statistics commit: 7bf8762acc8af4c010ab65ce8324b41ea59a361a [10/11] pbs-api-types: add notification thresholds to datastore config commit: 2804ddf6586be6bcb7b823b3e4d246b7a5717578 [11/11] pbs-api-types: add reset schedule for notification threshold counters commit: 2de5bc7585d588b334fdb19b528622858841317f